fix: refacto react-hook-form logic for roles based organizations #1471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: clegirar <[email protected]>
✅ Deploy Preview for teritori-dapp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for gno-dapp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: clegirar <[email protected]>
n0izn0iz
requested changes
Jan 2, 2025
| @@ -27,6 +29,35 @@ export type ConfigureVotingFormType = { | |||
| minutes: string; | |||
| }; | |||
|
|
|||
| export const ZodRoleObject = z.object({ | |||
There was a problem hiding this comment.
please don't capitalize zod schemas' names as they are objects and not types
Suggested change
| export const ZodRoleObject = z.object({ | |
| export const zodRoleObject = z.object({ |
Signed-off-by: clegirar <[email protected]>
clegirar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start a refacto about react-hook-form logic for roles based organizations.
The goal is to understand better the react-hook-form flow because it's a lot of abstractions. You can give your opinion if you find it more appropriate and understandable.
TODO:
Can't refacto
ConfigureVotingFormDataandOrganizationDatabecause it's generic between all organizations, but could be cool to adapt it.