[#12048] Migrate tests for GetReadNotificationsActionTest #13220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mingyang143
suggested changes
Feb 10, 2025
|
|
||
| @Test | ||
| protected void testExecute_getReadNotificationsAsInstructor_shouldSucceed() { | ||
| InstructorAttributes instructor = typicalBundle.instructors.get("instructor1OfCourse1"); |
There was a problem hiding this comment.
It looks like typicalBundle.instructors.get("instructor1OfCourse1") is related to the Google Datastore pre-migration. Would it be better to create the InstructorStub manually instead?
| loginAsInstructor(instructor.getGoogleId()); | ||
|
|
||
| List<NotificationAttributes> notificationAttributesList = List.of( | ||
| typicalBundle.notifications.get("notification1"), |
There was a problem hiding this comment.
Should typicalBundle be used here as well? This seems related to the previous comment.
|
|
||
| readNotificationsData.forEach(notificationId -> | ||
| assertTrue(testNotificationIds.contains(UUID.fromString(notificationId)))); | ||
| assertEquals(2, readNotificationsData.size()); |
There was a problem hiding this comment.
Aside from a few minor nits mentioned, the code is well-structured and effectively accomplishes its purpose!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #12048
Outline of Solution
Added the unit tests for GetReadNotificationsActionTest for PostgreSQL.