-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#12048] Migrate tests for DeleteFeedbackQuestionActionTest #13218
[#12048] Migrate tests for DeleteFeedbackQuestionActionTest #13218
Conversation
Add first test for execute() method.
Add more test for execute() Improve test names
Test specific access control for instructors with access control and without access control
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, small nits, but overall great job :)
src/test/java/teammates/sqlui/webapi/DeleteFeedbackQuestionActionTest.java
Outdated
Show resolved
Hide resolved
src/test/java/teammates/sqlui/webapi/DeleteFeedbackQuestionActionTest.java
Outdated
Show resolved
Hide resolved
Modified typo in test name Changed typicalInstructor to instructorWithoutAccess in test withoutModifySessionPrivilege
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, good work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Good work!
Part of #12048
Outline of Solution
Change DeleteFeedbackQuestionActionTest.java to ensure compatibility with the PostgreSQL database following the database migration.