Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#12048] Migrate tests for DeleteFeedbackQuestionActionTest #13218

Conversation

BunnyHoppp
Copy link
Contributor

Part of #12048

Outline of Solution

Change DeleteFeedbackQuestionActionTest.java to ensure compatibility with the PostgreSQL database following the database migration.

Add first test for execute() method.
Add more test for execute()

Improve test names
Test specific access control for
instructors with access control and
without access control
Copy link
Contributor

@domoberzin domoberzin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, small nits, but overall great job :)

Modified typo in test name

Changed typicalInstructor to
instructorWithoutAccess in test
withoutModifySessionPrivilege
Copy link
Contributor

@domoberzin domoberzin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good work!

Copy link
Contributor

@jasonqiu212 jasonqiu212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good work!

@jasonqiu212 jasonqiu212 added the s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging label Feb 15, 2025
@jasonqiu212 jasonqiu212 merged commit 2759096 into TEAMMATES:master Feb 15, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants