Enable Meta Pixels to be generated from just top or bottom pixels #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #148 +/- ##
==========================================
+ Coverage 73.56% 74.47% +0.90%
==========================================
Files 32 32
Lines 2016 2029 +13
==========================================
+ Hits 1483 1511 +28
+ Misses 533 518 -15 ☔ View full report in Codecov by Sentry. |
|
ping @samaloney for a review. |
samaloney
reviewed
Nov 20, 2024
samaloney
approved these changes
Jan 30, 2025
|
@DanRyanIrish made some small changes I'll merge if you are happy? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables users to generate their meta pixels for use in calculating STIX visibilities by only using top or bottom big pixels. This is needed in cases where the flare occurred at the edge of the STIX FOV, resulting in one row of pixels not being fully illuminated.