Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WP-870: Fix broken file uploads and APCD file submissions #1055

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

chandra-tacc
Copy link
Collaborator

@chandra-tacc chandra-tacc commented Feb 11, 2025

Overview

Upload is sending // to server and failing in url mapping.

Related

Changes

  1. url.replace does not modify in place, fix it.

Testing

  1. Added unit tests
  2. go to dev.apcd and try upload. and try upload

Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.56%. Comparing base (83dabae) to head (188c927).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1055      +/-   ##
==========================================
+ Coverage   70.48%   70.56%   +0.07%     
==========================================
  Files         538      538              
  Lines       34018    34018              
  Branches     2941     2947       +6     
==========================================
+ Hits        23979    24005      +26     
+ Misses       9839     9813      -26     
  Partials      200      200              
Flag Coverage Δ
javascript 72.76% <100.00%> (+0.09%) ⬆️
unittests 60.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
client/src/hooks/datafiles/mutations/useUpload.ts 40.95% <100.00%> (+24.76%) ⬆️

@chandra-tacc chandra-tacc marked this pull request as ready for review February 11, 2025 19:55
@chandra-tacc chandra-tacc changed the title fix upload with empty path WP-870: fix upload with empty path Feb 11, 2025
@chandra-tacc chandra-tacc changed the title WP-870: fix upload with empty path WP-870: Fix broken APCD file submissions Feb 11, 2025
@chandra-tacc chandra-tacc changed the title WP-870: Fix broken APCD file submissions WP-870: Fix broken file uploads and APCD file submissions Feb 11, 2025
@chandra-tacc chandra-tacc merged commit 0cd2c59 into main Feb 11, 2025
6 checks passed
@chandra-tacc chandra-tacc deleted the bug/WP-870 branch February 11, 2025 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants