Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task/WP-682: Fix Community Project Folders on Core portals #1041

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

fnets
Copy link
Contributor

@fnets fnets commented Jan 22, 2025

Overview

So that PIs can add to Community Data through the portal UI, we need to create a shared system that will point to the Community Data directory and allow PIs to add and remove users.

Related

Changes

  • Changed Shared System calls to target the tapis system being changed, rather than the root project.
  • Fixed bug where if a user had been added to a system without the proper permissions, it wouldn't break viewing the system for everyone.
  • Changed the setfacls job from a hardcoded path to a path taken from the rootdir of the system.

Testing

  1. Use the test community data system CEP-1308. If you don't have access, or need a permission change, send me a DM and I'll do it.
  2. Make sure you can add and remove files and directories.
  3. Make sure that you can add and remove users (as an owner).
  4. Make sure that you can still view the publicly-viewable Community Data.

UI

Notes

…ory (community data), the target of updating ACLs needs to be the system itself rather than the parent root system.
…permissions assigned, this function would fail which blocks the portal from getting the project at all.
…ion to use the system terminology instead of project terminology
… system will have the credentials needed for the job. Truncated the job name to fit with Tapis JSON requirements. And changed the client used to add a user to a shared system so that we know the system will have the credentials needed to make the change.
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.69%. Comparing base (c8e4f93) to head (00c9f7b).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1041      +/-   ##
==========================================
+ Coverage   70.48%   72.69%   +2.20%     
==========================================
  Files         538      327     -211     
  Lines       33985    27694    -6291     
  Branches     2936     2204     -732     
==========================================
- Hits        23956    20131    -3825     
+ Misses       9829     7525    -2304     
+ Partials      200       38     -162     
Flag Coverage Δ
javascript 72.69% <ø> (ø)
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 211 files with indirect coverage changes

@fnets fnets changed the title [DRAFT] task/WP-682: Fix Community Project Folders on Core portals task/WP-682: Fix Community Project Folders on Core portals Jan 22, 2025
Copy link
Collaborator

@chandra-tacc chandra-tacc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM.
Do you want to change this setting to true by default in settings.py?

PORTAL_PROJECTS_USE_SET_FACL_JOB = getattr(settings_custom, '_PORTAL_PROJECTS_USE_SET_FACL_JOB', False)

and unit tests need fix for merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants