-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
task/WP-682: Fix Community Project Folders on Core portals #1041
base: main
Are you sure you want to change the base?
Conversation
…ory (community data), the target of updating ACLs needs to be the system itself rather than the parent root system.
…permissions assigned, this function would fail which blocks the portal from getting the project at all.
…ion to use the system terminology instead of project terminology
… system will have the credentials needed for the job. Truncated the job name to fit with Tapis JSON requirements. And changed the client used to add a user to a shared system so that we know the system will have the credentials needed to make the change.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1041 +/- ##
==========================================
+ Coverage 70.48% 72.69% +2.20%
==========================================
Files 538 327 -211
Lines 33985 27694 -6291
Branches 2936 2204 -732
==========================================
- Hits 23956 20131 -3825
+ Misses 9829 7525 -2304
+ Partials 200 38 -162
Flags with carried forward coverage won't be shown. Click here to find out more. |
server/portal/apps/projects/workspace_operations/shared_workspace_operations.py
Outdated
Show resolved
Hide resolved
server/portal/apps/projects/workspace_operations/shared_workspace_operations.py
Show resolved
Hide resolved
server/portal/apps/projects/workspace_operations/shared_workspace_operations.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and LGTM.
Do you want to change this setting to true by default in settings.py?
PORTAL_PROJECTS_USE_SET_FACL_JOB = getattr(settings_custom, '_PORTAL_PROJECTS_USE_SET_FACL_JOB', False)
and unit tests need fix for merging.
Overview
So that PIs can add to Community Data through the portal UI, we need to create a shared system that will point to the Community Data directory and allow PIs to add and remove users.
Related
Changes
Testing
UI
Notes