Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View users - fixed filter by organization #87

Merged
merged 8 commits into from
Feb 3, 2023
Merged

View users - fixed filter by organization #87

merged 8 commits into from
Feb 3, 2023

Conversation

davidmtacc
Copy link
Contributor

Overview

Fixed filter by organization

Related

Changes

Dropdown list populated by organizations field
Table filtered by Organizations
Organization list in dropdown has duplicates removed
OrderBy Organization in amended DB Query
Changed RoleID to Role ID in table headings

Testing

  1. tested listing of organizations in dropdown with local data
  2. tested removal of duplicates in dropdown listing
  3. tested filtering of table by dropdown
  4. Table heading change tested

UI

davidmtacc and others added 7 commits January 24, 2023 08:33
Authentication commented out for testing. Removing comments
Added organization dropdown using organizations from table but removing duplicates from dropdown list. Amended db query to orderby orgs
Fixed column heading Role ID
@sophia-massie sophia-massie self-requested a review February 3, 2023 01:27
Copy link
Contributor

@sophia-massie sophia-massie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Filter works as expected. Need to resolve conflicts with main and should be good to move to staging!

@fnets fnets merged commit 2ff166f into main Feb 3, 2023
@fnets fnets deleted the view-users branch February 3, 2023 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants