Move from kovan to goerli #199
Open
+3,644
−169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xjocke
commented
Aug 1, 2022
| if (i === 0 && (getCurrentNetwork() !== 'optimism' || getCurrentNetwork() !== 'optimism-kovan')) { | ||
| if ( | ||
| (i === 0 && (getCurrentNetwork() !== 'optimism' || getCurrentNetwork() !== 'optimism-goerli')) || | ||
| getCurrentNetwork() !== 'goerli' |
There was a problem hiding this comment.
Here I assumed that guerli doesn't need to track exchanger_SynthetixOldTracking
0xjocke
commented
Aug 1, 2022
| @@ -127,7 +127,7 @@ exchangeRatesContractAddresses.forEach((ca, i) => { | |||
| }); | |||
| }); | |||
|
|
|||
| if (getCurrentNetwork() === 'mainnet' || getCurrentNetwork() == 'kovan') { | |||
| if (getCurrentNetwork() === 'mainnet' || getCurrentNetwork() == 'goerli') { | |||
| // hack for chainlink, tracking of aggregator address changes | |||
There was a problem hiding this comment.
Not sure if this chainlink hack is required for goerli too?
0xjocke
commented
Aug 1, 2022
0xjocke
requested review from
noahlitvin and
dbeal-eth
and removed request for
noahlitvin
|
Also, if any of you have admin rights could you add @nosekit |
|
Deployed to goerli under my account and fully synced The graph still haven't got support for goerli-optimism |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
js-monrepo require goerli subgraphs to be defined. Left some question and I will also need help to deploy since I dont have the access key for our account