Use access token #188
Open
Use access token #188
+88
−86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xjocke
commented
May 5, 2022
| if (settings.network === 'None') { | ||
| // With the old logic, if network was None and deployDecentralized is true we would NOT build and try to deploy to decentralised network. | ||
| // I think we dont want to deploy anything when network is None? | ||
| return; |
There was a problem hiding this comment.
Will remove this comment if my assumption is correct
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
access-tokenparameter was not used for the hosted service deployment and used incorrectly for the decentralised deployment (it's camel cased on the settings object)My first commit resolved the problem. The nested if statement and repetition of build/deploy exec triggered my refactor brain. I created
buildAndDeployHostedanddeployDecentralizedto make it a little easier to reason about, hopefully you agree with that.I also remove some await for non async functions