-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #75: detect sass
binary in the path and use it if available
#76
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, correct me if I'm wrong but you're trying to prioritize the binary from paths among other available binaries. I see this bundle allows to specify the path to the binary you want to use, see: https://symfony.com/bundles/SassBundle/current/index.html#using-a-different-binary - so it already works the way you need, i.e. you can just specify the path to the local binary from path and it will work for you, right? The only problem with this behaviour is that you need to specify that path manually. In case we want to automate it - we need to follow the next logic IMO:
- Check if the binary path is set in the config, i.e.
symfonycasts_sass.binary
option. if it's set - just use it, no need to find anything because it's explicitly configured - If no
symfonycasts_sass.binary
option is set - try to find the installed binary from the path as you suggest. If found - use it. - If no installed binary in the path - try to download the latest binary.
OK will adjust my PR then ! Thank you for the review! |
Also, tests and code styles were fixed in #73 , please, release your PR |
@bocharsky-bw Ready for another review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me now, thanks for this idea!
Add more information about the bundle's behaviour after #76
Add more information about the bundle's behaviour after #76
This PR fix #75 by doing:
sass
if it is available in the path