Skip to content

Commit

Permalink
Fix CI (#73)
Browse files Browse the repository at this point in the history
* Constrain PHPUnit to < v10

* Apply new changes from PHP CS Fixer

* Try PHPUnit 9.6 for simple-phpunit

* Bump symfony/phpunit-bridge to ^6.3.9 to fix error w/ lowest
  • Loading branch information
bocharsky-bw authored Oct 10, 2024
1 parent 2ebbf33 commit befe180
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 5 deletions.
5 changes: 4 additions & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"require-dev": {
"matthiasnoback/symfony-config-test": "^5.0",
"symfony/framework-bundle": "^6.3|^7.0",
"symfony/phpunit-bridge": "^6.3|^7.0"
"symfony/phpunit-bridge": "^6.3.9|^7.0"
},
"minimum-stability": "dev",
"autoload": {
Expand All @@ -34,6 +34,9 @@
"Symfonycasts\\SassBundle\\Tests\\": "tests/"
}
},
"conflict": {
"phpunit/phpunit": ">=10"
},
"scripts": {
"tools:upgrade": [
"@tools:upgrade:php-cs-fixer",
Expand Down
2 changes: 1 addition & 1 deletion phpunit.xml.dist
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
<server name="APP_ENV" value="test" force="true" />
<server name="SHELL_VERBOSITY" value="-1" />
<server name="SYMFONY_PHPUNIT_REMOVE" value="" />
<server name="SYMFONY_PHPUNIT_VERSION" value="9.5" />
<server name="SYMFONY_PHPUNIT_VERSION" value="9.6" />
</php>

<testsuites>
Expand Down
2 changes: 1 addition & 1 deletion src/AssetMapper/SassCssCompiler.php
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ public function __construct(
private array $scssPaths,
private string $cssPathDirectory,
private string $projectDir,
private readonly SassBuilder $sassBuilder
private readonly SassBuilder $sassBuilder,
) {
}

Expand Down
2 changes: 1 addition & 1 deletion src/Command/SassBuildCommand.php
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
class SassBuildCommand extends Command
{
public function __construct(
private SassBuilder $sassBuilder
private SassBuilder $sassBuilder,
) {
parent::__construct();
}
Expand Down
2 changes: 1 addition & 1 deletion src/SassBinary.php
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ public function __construct(
private string $binaryDownloadDir,
private ?string $binaryPath = null,
private ?SymfonyStyle $output = null,
?HttpClientInterface $httpClient = null
?HttpClientInterface $httpClient = null,
) {
$this->httpClient = $httpClient ?? HttpClient::create();
}
Expand Down

0 comments on commit befe180

Please sign in to comment.