Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Salaam,
I added two more apps so that total number will be 155. I need to edit readme as well but I'm little bit lost because there are two branches. Ok I will do it إن شاء الله when I know how! I'm searching
One small note:
I think we should delete -> Bool from👇🏼
public func open<E: ExternalApplication>(_ externalApp: E, action: E.ActionType, promptInstall: Bool = false) -> Bool {
And we should delete it here as well:
func openURL(_ url: URL) -> Bool
Because it's really annoying when developer get this warning and then silent it with let _
Result of call to 'open(_:action:promptInstall:)' is unused
I got the above warning for each app when I wrote this for example:
apps.open(Applications.Skitch(), action: .open)
Do you agree with me?