-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider simplifying ExternalApp structure #35
Comments
This looks great, I have a question we used ExternalApplication instead of calling openURL because of this 👇🏼 |
nah, this is just a refactor to organize the library API |
This is real nice, we'll need to support this when it comes out, yes. |
Salaam, I need to know still we need to support iOS 9 ? because I think it's better to use iOS 10 new method: There is a solution if we need to support iOS 9 but I just need to know to save some lines of code. |
This is a different feature, so I created a new issue for that here: #82 |
Having added applications inherit
ExternalApplication
gives us a lot of flexibility, but I am starting to question the need for such a flexible design. Perhaps making it a simple struct instance would reduce all the boilerplate code written for the added apps... Need to investigate.The text was updated successfully, but these errors were encountered: