fix(Save): Refresh without file-watcher #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asyncRefresh() was used until now, but this method relies on a file-watcher. As a consequence, the following statement (reloadFromDisk) happens before the file can be marked as dirty, which makes the first call to reloadFromDisk() use the idea cache. Use refreshWithoutFileWatcher() instead, to make sure that the file is refreshed before the next call to reloadFromDisk().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
syncRefresh() was used until now, but this method relies on a file-watcher.
As a consequence, the following statement (reloadFromDisk), would be played
before the file can be marked as dirty, and potentially be wrong.
This creates the following bug :
If one opens a file, modifies it so that a diagnostic message appears, and then saves it,
then the diagnostic message is also going to disappear, because Intellij is going to
"reload" a file from its internal cache, and is not going to take the change into account.
Use refreshWithoutFileWatcher() instead, to make sure that the file is refreshed before
reloadFromDisk() is called.