Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import StuyLib to 2024 WPILib #82

Merged
merged 12 commits into from
Jan 8, 2024
Merged

Import StuyLib to 2024 WPILib #82

merged 12 commits into from
Jan 8, 2024

Conversation

anivanchen
Copy link
Member

No description provided.

Sam-Belliveau
Sam-Belliveau approved these changes Dec 3, 2023
View reviewed changes
Copy link
Collaborator

@Sam-Belliveau Sam-Belliveau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I probably shouldnt be reviewing these anymore, maybe theres an issue for who needs to approve PRs. But this looks good to me and it builds.

this is a nitpick and unrelated to this pr but can we make SmartBoolean and SmartString final. :)

@BenG49 BenG49 requested a review from Sam-Belliveau January 8, 2024 03:15
@BenG49 BenG49 merged commit 576046c into main Jan 8, 2024
6 checks passed
@BenG49 BenG49 deleted the 2024 branch January 8, 2024 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@selym3 selym3 Awaiting requested review from selym3

@Sam-Belliveau Sam-Belliveau Awaiting requested review from Sam-Belliveau

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anivanchen @Sam-Belliveau @BenG49