Implements DefaultDataSink dynamic queue #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kseito
reviewed
Jan 28, 2022
| bufferInfo.set(offset, sample.mSize, sample.mTimeUs, sample.mFlags); | ||
| writeTrack(sample.mType, mQueueBuffer, bufferInfo); | ||
| offset += sample.mSize; | ||
| bufferInfo.set(0, sample.mSize, sample.mTimeUs, sample.mFlags); |
There was a problem hiding this comment.
offsetが常に0が入るようになっていますが問題ないですか？（内部で使われていない？）
There was a problem hiding this comment.
1つのBufferに1回しか書き込まないので常に0で問題なしです！
There was a problem hiding this comment.
そうか。QueuedSampleにBufferを持たせるように変えたからBufferの参照方法も変わりますね。
良さそう。
kseito
approved these changes
Jan 28, 2022
| bufferInfo.set(offset, sample.mSize, sample.mTimeUs, sample.mFlags); | ||
| writeTrack(sample.mType, mQueueBuffer, bufferInfo); | ||
| offset += sample.mSize; | ||
| bufferInfo.set(0, sample.mSize, sample.mTimeUs, sample.mFlags); |
There was a problem hiding this comment.
そうか。QueuedSampleにBufferを持たせるように変えたからBufferの参照方法も変わりますね。
良さそう。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see https://github.com/natario1/Transcoder/pull/166
動作確認しないよう
10秒の動画で確認したところ34Bufferがキューに貯まりました。
10分の動画で確認したところ35Bufferがキューに貯まりました。
動画の長さ（≒サイズ）によって線形にキューが増える（＝メモリ使用量が増える）ではなさそうなのでこの実装で問題ないと判断しています。