Fixes to several patterns

VortexEngine/src/Patterns/Multi/CrossDopsPattern.cpp

@@ -19,7 +19,7 @@ void CrossDopsPattern::init()
 {
   BlinkStepPattern::init();
   // Alternating evens and odds mapping of leds to turn on/off
-  m_ledMap = MAP_PAIR_EVENS;
+  m_ledMap = MAP_LINE_1;
   // start colorset at index 0 so cur() works
   m_colorset.setCurIndex(0);
 }

VortexEngine/src/Patterns/Multi/FillPattern.cpp

@@ -28,13 +28,13 @@ void FillPattern::init()
 
 void FillPattern::blinkOn()
 {
-  Leds::setQuadrants(QUADRANT_FIRST, (Quadrant)m_progress, m_colorset.peekNext());
-  Leds::setQuadrants((Quadrant)m_progress, QUADRANT_LAST, m_colorset.cur());
+  Leds::setRange(LED_FIRST, LedPos(m_progress * (LED_COUNT / 4)), m_colorset.peekNext());
+  Leds::setRange(LedPos(LED_COUNT / 4), LED_LAST, m_colorset.cur());
 }
 
 void FillPattern::poststep()
 {
-  m_progress = (m_progress + 1) % PAIR_COUNT;
+  m_progress = (m_progress + 1) % 4;
   if (m_progress == 0) {
     m_colorset.getNext();
   }

VortexEngine/src/Patterns/Multi/MeteorPattern.cpp

@@ -34,8 +34,10 @@ void MeteorPattern::blinkOff()
 
 void MeteorPattern::poststep()
 {
-  // when a new meteor is created it is incerted into the stash so the blinking pattern is not interrupted
-  LedPos target = (LedPos)m_randCtx.next8(LED_FIRST, LED_LAST);
-  RGBColor col = m_colorset.getNext();
-  m_stash.setIndex(target, col);
+  for (int meteorCount = 0; meteorCount < (LED_COUNT / 2); ++meteorCount) {
+    // when a new meteor is created it is incerted into the stash so the blinking pattern is not interrupted
+    LedPos target = (LedPos)m_randCtx.next8(LED_FIRST, LED_LAST);
+    RGBColor col = m_colorset.getNext();
+    m_stash.setIndex(target, col);
+  }
 }

VortexEngine/src/Patterns/Multi/Sequencer/ChaserPattern.cpp

@@ -13,7 +13,7 @@ ChaserPattern::ChaserPattern(const PatternArgs &args) :
   setArgs(args);
 
   // Makes sure there is at least 1 chaser
-  uint8_t numChasers = LED_COUNT / CHASER_RATIO;
+  uint32_t numChasers = LED_COUNT / CHASER_RATIO;
   if (!numChasers) {
     numChasers = 1;
   }
@@ -33,7 +33,7 @@ ChaserPattern::ChaserPattern(const PatternArgs &args) :
     // which will use the 0th color from the colorset as the solid color.
     // An LedMap is a bitmap that indicates which leds are turned on or off
     // at any given time. This will generate an Led Map based on the current
-    LedMap overrideLeds = 0; 
+    LedMap overrideLeds = MAP_LED_NONE; 
     // This creates an led map with 1 chaser per CHASER_RATIO (default 7) leds in LED_COUNT
     for (int chaserCount = 0; chaserCount < numChasers; ++chaserCount) {
       overrideLeds |= MAP_LED((i + (chaserCount * CHASER_RATIO)) % LED_COUNT);

VortexEngine/src/Patterns/Multi/ZigzagPattern.cpp

@@ -4,25 +4,8 @@
 #include "../../Leds/Leds.h"
 #include "../../Log/Log.h"
 
-// Mapping of LED positions to steps.
-// The lights runs across evens, then back across odds.
-// Index this array with m_step in order to get correct LedPos
-const LedPos ZigzagPattern::ledStepPositions[] = {
-  LED_1,
-  LED_3,
-  LED_5,
-  LED_7,
-  LED_9,
-
-  LED_8,
-  LED_6,
-  LED_4,
-  LED_2,
-  LED_0,
-};
-
 // There just happens to be LED_COUNT steps in the pattern
-#define NUM_ZIGZAG_STEPS (sizeof(ledStepPositions) / sizeof(ledStepPositions[0]))
+#define NUM_ZIGZAG_STEPS LED_COUNT
 #define HALF_ZIGZAG_STEPS (NUM_ZIGZAG_STEPS / 2)
 
 ZigzagPattern::ZigzagPattern(const PatternArgs &args) :
@@ -159,7 +142,7 @@ void ZigzagPattern::Snake::drawSnake()
       col.adjustBrightness(m_fadeAmount * segment);
     }
     // lookup the target in the step positions array and turn it on with given color/brightness
-    Leds::setIndex(ledStepPositions[segment_position], col);
+    Leds::setIndex((LedPos)segment_position, col);
     // if this segment is on the step where the color changes
     if (segment_position == m_changeBoundary) {
       // then decrement the color index for the rest of the snake so that the

VortexEngine/src/Patterns/Multi/ZigzagPattern.h

@@ -39,10 +39,6 @@ class ZigzagPattern : public MultiLedPattern
     uint8_t m_fadeAmount;
     uint8_t m_changeBoundary;
   };
-
-  // path for leds to take, index this with m_step up to LED_COUNT steps
-  static const LedPos ledStepPositions[];
-
   // blink on duration
   uint8_t m_onDuration;
   // blink off duration