fixed build for spark

StoneOrbits · Dec 10, 2024 · e5c7624 · e5c7624
1 parent e69481c
commit e5c7624
Showing 1 changed file with 15 additions and 15 deletions.
diff --git a/.github/workflows/spark_build.yml b/.github/workflows/spark_build.yml
@@ -89,19 +89,18 @@ jobs:
           export VORTEX_BUILD_NUMBER=${{ needs.setup.outputs.vortex_build_number }}
           export VORTEX_VERSION_NUMBER=${{ needs.setup.outputs.vortex_version_number }}
           make build
-      - name: Archive production artifacts
-        uses: actions/upload-artifact@v4
-        with:
-          name: embedded firmware
-          path: |
+      - name: Zip firmware files
+        run: |
+          zip SparkFirmware.zip \
+            build/VortexEngine.ino.bootloader.bin \
+            build/VortexEngine.ino.partitions.bin \
+            ~/.arduino15/packages/esp32/hardware/esp32/3.0.4/tools/partitions/boot_app0.bin \
             build/VortexEngine.ino.bin
-            build/VortexEngine.ino.elf
-            build/VortexEngine.ino.map
-      - name: Archive production artifacts for deployment
+      - name: Archive firmware zip
         uses: actions/upload-artifact@v4
         with:
-          name: firmware-artifact
-          path: build/VortexEngine.ino.bin
+          name: spark-firmware-zip
+          path: SparkFirmware.zip
 
   wasm:
     needs: [setup, test, embedded]
@@ -130,7 +129,8 @@ jobs:
         working-directory: VortexEngine/VortexLib
 
   docs:
-    needs: [setup, test, embedded, wasm]
+    #todo: fix the depends to be setup, test, embedded, wasm
+    needs: [setup, test]
     runs-on: ubuntu-latest
     if: github.ref == 'refs/heads/spark'
     steps:
@@ -162,15 +162,15 @@ jobs:
       - uses: actions/checkout@v4
       - uses: actions/download-artifact@v4
         with:
-          name: firmware-artifact
+          name: spark-firmware-zip
           path: build
       - name: Rename and Deploy Firmware
         run: |
           DEVICE_TYPE="spark"
-          VERSIONED_FILENAME="VortexEngine-${DEVICE_TYPE}-${{ needs.setup.outputs.vortex_version_number }}.bin"
-          mv build/VortexEngine.ino.bin build/$VERSIONED_FILENAME
+          VERSIONED_FILENAME="VortexEngine-${DEVICE_TYPE}-${{ needs.setup.outputs.vortex_version_number }}.zip"
+          mv build/SparkFirmware.zip build/$VERSIONED_FILENAME
           echo "Version is ${{ needs.setup.outputs.vortex_version_number }}"
-          echo "Filename is is $VERSIONED_FILENAME"
+          echo "Filename is $VERSIONED_FILENAME"
           curl -X POST \
             -F "file=@build/$VERSIONED_FILENAME" \
             -F "device=$DEVICE_TYPE" \