Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Detox tests for each top-level "module" and tab #6800

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

hawkrives
Copy link
Member

@hawkrives hawkrives commented Jan 27, 2023

  • add detox tests for each module/tab
  • test out running multiple simulators on the same macos box (seeing if running 3 simulators is faster than 1, since the macOS boxes are tri-core)

Part of #6788

@hawkrives hawkrives changed the title hawken/more detox tests Add Detox tests for each top-level "module" and tab Jan 27, 2023
@hawkrives
Copy link
Member Author

hawkrives commented Jan 27, 2023

Before I can bring this out of Draft, I need:

  • detox to work on CI
  • to implement shorter timeouts for our tests - no single test takes over 10s, so I propose that instead of the current 120s
  • to figure out if one, two, or three parallel runners work best
  • to figure out if we should shard the runners across machines too

@drewvolz
Copy link
Member

As far as I can tell, CI should be passing if we weren't using live data for the menus (Carleton menus show "Closed for spring break")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants