🧪 Add end-to-end tests for navigation #4013

rye · 2019-09-15T16:27:46Z

I like testing.

Testing is good.

"We should test more stuff" has been a long-standing thing I've said, but here I'm actually trying my hand at e2e testing.

I'm Not Sure™ if this affects coverage at all. It'd be nice if it did, but I don't think Detox instruments that yet, or if they do, I don't think we're uploading that. So, I guess I just have to give this a try.

list of views to test moved to #6788

Signed-off-by: Kristofer Rye <[email protected]>

e2e/streaming.spec.js

codecov · 2019-09-15T16:33:29Z

Codecov Report

Merging #4013 (f64c56d) into master (c2358b2) will not change coverage.
The diff coverage is 0.00%.

Additional details and impacted files

@@          Coverage Diff           @@
##           master   #4013   +/-   ##
======================================
  Coverage    8.59%   8.59%           
======================================
  Files         298     298           
  Lines        5097    5097           
  Branches     1383    1383           
======================================
  Hits          438     438           
  Misses       4636    4636           
  Partials       23      23

hawkrives · 2019-09-15T16:34:05Z

I think we should tweak the Detox tests to not reinstall the app before every test. I don’t remember why I did that originally.

hawkrives · 2019-09-15T16:36:06Z

Anyway, ideas:

Calendar, tap first item in the list of there are any items
Building Hours, same thing
Settings, assert that the Sign In button is visible?

Also, instead of deleting and reinstalling the app before each individual test, (which is overkill) just launch a new instance of the app. Signed-off-by: Kristofer Rye <[email protected]>

rye · 2019-09-15T16:55:48Z

I have taken care of the relaunching behavior in 6dd0d1f.

Signed-off-by: Kristofer Rye <[email protected]>

rye · 2019-09-15T18:00:32Z

So I can't find my testID because "React Native only supports the testID prop on the native built-in components."

It sounds like I have to manually propagate that through to the appropriate element.

Signed-off-by: Kristofer Rye <[email protected]>

Since screen-streaming is actually just a TabNavigator, and I can't quite figure out how to set the testID on it, I'm going to ignore it and see if I can get a passing build Signed-off-by: Kristofer Rye <[email protected]>

Signed-off-by: Kristofer Rye <[email protected]>

rye · 2019-09-15T20:23:04Z

Hey, a passing build!

drewvolz · 2019-09-20T22:24:33Z

I am doing this primarily to get the up-to-date GitHub Actions workflows and such, but also the changes that have been made to various views. Signed-off-by: Kristofer Rye <[email protected]>

Signed-off-by: Kristofer Rye <[email protected]>

drewvolz · 2022-05-28T06:45:42Z

I realize these have been sitting in this PR but probably can be merged in as they are written. Is there anything besides resolving conflicts that we need to do to get these in?

hawkrives · 2023-01-20T23:41:43Z

Riffing from @drewvolz's comment, I think that once we get Detox working again this should be only a small amount of work to merge!

* master: (2979 commits) update Podfile.lock update theme import and change names use standard "black" color switch codecov from the bash uploader to their action add new "dependency review" workflow add whitespace to "check" workflow jobs make the Prettier job's ID match its name upgrade linux runners to ubuntu-22.04 centralize global versions for languages and Xcode auto-cancel in-progress jobs on subsequent commit to the same branch add distributionSha256Sum to gradle-wrapper.properties implement auto-cache-cleanup workflow Bump react-native-paper from 4.12.4 to 5.1.4 Bump babel-jest from 29.3.1 to 29.4.0 Bump @jest/globals from 29.3.1 to 29.4.0 Bump @typescript-eslint/parser from 5.48.2 to 5.49.0 Bump react-native-network-logger from 1.13.0 to 1.14.0 Bump @typescript-eslint/eslint-plugin from 5.48.2 to 5.49.0 Bump jest from 29.3.1 to 29.4.0 Bump @react-native-community/datetimepicker from 6.7.2 to 6.7.3 ...

hawkrives · 2023-01-24T16:10:03Z

  ● Streaming Media View › has the Stream List visible by default

    Test Failed: No elements found for “MATCHER(id == “homescreen-button-StreamingView”)”

    HINT: To print view hierarchy on failed actions/matches, use log-level verbose or higher.

      30 | 	it('has the Stream List visible by default', async () => {
      31 | 		// Navigate into StreamingView
    > 32 | 		await element(by.id('homescreen-button-StreamingView')).tap()
         | 		                                                        ^
      33 |
      34 | 		// The stream-list should be visible now
      35 | 		await expect(element(by.id('stream-list'))).toBeVisible()

      at Object.<anonymous> (e2e/streaming.spec.ts:32:59)

Working on this part next…

hawkrives · 2023-01-24T22:57:56Z

ready!

…lement ID

rye

I can't ✅ this but I love it! This certainly seems to be going in the right direction.

As to overall strategy, I do think it's worth us exploring either mocking or full parametrization of things so that we have more control over data we expect to see in the app from the test suite and so that we can verify more tightly. However, I think we should do that in a separate MR — I think that's part of the larger infrastructurification push.

hawkrives · 2023-01-25T01:41:54Z

I fully agree! And I agree about that being a separate effort - we'll get a lot of value just from having the assurance that every view is reachable by navigating the app, I think!

rye added 2 commits September 15, 2019 11:23

Add a few testIDs to some things

3a3cece

Signed-off-by: Kristofer Rye <[email protected]>

Add some e2e tests for navigation into the streaming view

403e3a3

Signed-off-by: Kristofer Rye <[email protected]>

rye added tool/detox testing related to testing labels Sep 15, 2019

rye self-assigned this Sep 15, 2019

rye changed the title ~~Add end-to-end tests for navigation~~ 🧪 Add end-to-end tests for navigation Sep 15, 2019

Sort props alphabetically, apparently

1cc3c04

Signed-off-by: Kristofer Rye <[email protected]>

hawkrives reviewed Sep 15, 2019

View reviewed changes

e2e/streaming.spec.js Outdated Show resolved Hide resolved

Replace deprecated relaunchApp call with launchApp call

6dd0d1f

Also, instead of deleting and reinstalling the app before each individual test, (which is overkill) just launch a new instance of the app. Signed-off-by: Kristofer Rye <[email protected]>

rye added 2 commits September 15, 2019 11:56

Use tabBarTestID to find buttons instead of text search

b32b095

Signed-off-by: Kristofer Rye <[email protected]>

Try to fix an issue with not getting testIDs found

6a70a54

Signed-off-by: Kristofer Rye <[email protected]>

Rename HomeScreenButton props and support testID on inner view

647d9e8

Signed-off-by: Kristofer Rye <[email protected]>

rye force-pushed the more-testing branch from 96ee2f9 to 647d9e8 Compare September 15, 2019 18:04

rye added 2 commits September 15, 2019 13:31

s/toNotBe/toBeNot/g

1341de4

Signed-off-by: Kristofer Rye <[email protected]>

streaming: Remove assertion of screen-streaming

3c57af3

Since screen-streaming is actually just a TabNavigator, and I can't quite figure out how to set the testID on it, I'm going to ignore it and see if I can get a passing build Signed-off-by: Kristofer Rye <[email protected]>

rye force-pushed the more-testing branch from 90623f0 to 3c57af3 Compare September 15, 2019 19:34

Add testID prop support to RadioControllerView

ba9072c

Signed-off-by: Kristofer Rye <[email protected]>

rye added 4 commits October 13, 2019 15:31

Merge branch 'master' into more-testing

71f9d4a

I am doing this primarily to get the up-to-date GitHub Actions workflows and such, but also the changes that have been made to various views. Signed-off-by: Kristofer Rye <[email protected]>

e2e: Break apart the Streaming tests a bit more

ca242b7

Signed-off-by: Kristofer Rye <[email protected]>

e2e: Also test the KRLX Radio view

f6d345d

Signed-off-by: Kristofer Rye <[email protected]>

Merge branch 'master' into more-testing

8bcb3cc

hawkrives mentioned this pull request Jan 24, 2023

E2E tests should test that every view is visible #6788

Open

68 tasks

hawkrives marked this pull request as ready for review January 24, 2023 16:09

hawkrives requested a review from drewvolz as a code owner January 24, 2023 16:09

hawkrives marked this pull request as draft January 24, 2023 16:09

hawkrives marked this pull request as ready for review January 24, 2023 22:57

drewvolz approved these changes Jan 24, 2023

View reviewed changes

hawkrives added 13 commits January 24, 2023 18:48

port changes from this PR to the TS files

dd651f6

fix ts error in homescreen button

5cc8b75

fix missed merge conflict

b40a0b6

don't forget to launch the app!

652ddf0

clean up implementation of homescreen buttons

d6bf307

fix test for expected button targets

de66a4d

remove deprecated "toBeNotVisible" method

ec82798

wait for the tab bar to finish appearing before tapping the tabs

c3c50d6

add test to open the Webcams screen

f06f76c

simplify webcam button component

e1d489a

rework streaming-media tests to run by user-facing text, instead of e…

90cf702

…lement ID

remove more id matchers

70a77c8

remove an ID matcher from the basic test

1f553a3

hawkrives force-pushed the more-testing branch from 8955e25 to 1f553a3 Compare January 24, 2023 23:52

remove test-ids from the homescreen buttons

f64c56d

rye commented Jan 25, 2023

View reviewed changes

hawkrives merged commit 5101d26 into master Jan 25, 2023

hawkrives deleted the more-testing branch January 25, 2023 01:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🧪 Add end-to-end tests for navigation #4013

🧪 Add end-to-end tests for navigation #4013

rye commented Sep 15, 2019 •

edited by hawkrives

Loading

codecov bot commented Sep 15, 2019 •

edited

Loading

hawkrives commented Sep 15, 2019

hawkrives commented Sep 15, 2019

rye commented Sep 15, 2019

rye commented Sep 15, 2019

rye commented Sep 15, 2019

drewvolz commented Sep 20, 2019

Home

Menus

SIS

Building hours

Calendar

Directory

Streaming Media

News

Map

Important Contacts

Transit

Dictionary

Student Orgs

Moodle

Report a Problem

stoPrint

Safety Concerns

Settings

Smaller Fish

Developer

Integrated but not visible

drewvolz commented May 28, 2022

hawkrives commented Jan 20, 2023

hawkrives commented Jan 24, 2023

hawkrives commented Jan 24, 2023

rye left a comment

hawkrives commented Jan 25, 2023

🧪 Add end-to-end tests for navigation #4013

🧪 Add end-to-end tests for navigation #4013

Conversation

rye commented Sep 15, 2019 • edited by hawkrives Loading

codecov bot commented Sep 15, 2019 • edited Loading

Codecov Report

hawkrives commented Sep 15, 2019

hawkrives commented Sep 15, 2019

rye commented Sep 15, 2019

rye commented Sep 15, 2019

rye commented Sep 15, 2019

drewvolz commented Sep 20, 2019

Home

Menus

SIS

Building hours

Calendar

Directory

Streaming Media

News

Map

Important Contacts

Transit

Dictionary

Student Orgs

Moodle

Report a Problem

stoPrint

Safety Concerns

Settings

Smaller Fish

Developer

Integrated but not visible

drewvolz commented May 28, 2022

hawkrives commented Jan 20, 2023

hawkrives commented Jan 24, 2023

hawkrives commented Jan 24, 2023

rye left a comment

Choose a reason for hiding this comment

hawkrives commented Jan 25, 2023

rye commented Sep 15, 2019 •

edited by hawkrives

Loading

codecov bot commented Sep 15, 2019 •

edited

Loading