Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add obsid info #863

Merged
merged 2 commits into from
Nov 22, 2024
Merged

Add obsid info #863

merged 2 commits into from
Nov 22, 2024

Conversation

matteobachetti
Copy link
Member

This is a trivial addition: when present, the OBS_ID header keyword is read and added to the meta information of the FitsTimeseriesReader (and the EventList that will be created from it)

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.05%. Comparing base (b2e6e1a) to head (9faeebf).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #863      +/-   ##
==========================================
+ Coverage   94.21%   96.05%   +1.83%     
==========================================
  Files          48       48              
  Lines        9687     9689       +2     
==========================================
+ Hits         9127     9307     +180     
+ Misses        560      382     -178     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Collaborator

@eleonorav89 eleonorav89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No comments from me, and thank you for your work

@matteobachetti matteobachetti added this pull request to the merge queue Nov 22, 2024
Merged via the queue into main with commit 10cfb78 Nov 22, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants