sendfile_posix: only use *64 APIs when _LARGEFILE64_SOURCE is defined

*64 APIS are considered deprecated and should not be used unless _LARGEFILE64_SOURCE is explicitly defined.
Stiffstream · Mar 17, 2024 · 7e125f8 · 7e125f8
1 parent 7994a15
commit 7e125f8
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/dev/restinio/impl/sendfile_operation_posix.ipp b/dev/restinio/impl/sendfile_operation_posix.ipp
@@ -41,7 +41,7 @@ class sendfile_operation_runner_t final
 		virtual void
 		start() override
 		{
-#if defined( RESTINIO_FREEBSD_TARGET ) || defined( RESTINIO_MACOS_TARGET )
+#if !defined( _LARGEFILE64_SOURCE )
 			auto const n = ::lseek( this->m_file_descriptor, this->m_next_write_offset, SEEK_SET );
 #else
 			auto const n = ::lseek64( this->m_file_descriptor, this->m_next_write_offset, SEEK_SET );
@@ -274,11 +274,19 @@ class sendfile_operation_runner_t< asio_ns::ip::tcp::socket > final
 		auto
 		call_native_sendfile() noexcept
 		{
+#if defined( _LARGEFILE64_SOURCE )
 			return ::sendfile64(
 					m_socket.native_handle(),
 					m_file_descriptor,
 					&m_next_write_offset,
 					std::min< file_size_t >( m_remained_size, m_chunk_size ) );
+#else
+			return ::sendfile(
+					m_socket.native_handle(),
+					m_file_descriptor,
+					&m_next_write_offset,
+					std::min< file_size_t >( m_remained_size, m_chunk_size ) );
+#endif
 		}
 #endif
 

diff --git a/dev/restinio/sendfile_defs_posix.hpp b/dev/restinio/sendfile_defs_posix.hpp
@@ -100,7 +100,7 @@ get_file_meta( file_descriptor_t fd )
 		throw exception_t{ "invalid file descriptor" };
 	}
 
-#if defined( RESTINIO_FREEBSD_TARGET ) || defined( RESTINIO_MACOS_TARGET )
+#if !defined( _LARGEFILE64_SOURCE )
 	struct stat file_stat;
 
 	const auto fstat_rc = ::fstat( fd, &file_stat );