-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HyperlinkedImage + OrderedList components #13
base: dev
Are you sure you want to change the base?
Conversation
Hey, thanks a lot for your contribution! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice if you could also add examples to the readme and maybe some test cases. If you don't feel like it that's also fine, in that case I'll do it later.
Source/MarkdownGenerator/src/main/java/net/steppschuh/markdowngenerator/list/OrderedList.java
Outdated
Show resolved
Hide resolved
Source/MarkdownGenerator/src/main/java/net/steppschuh/markdowngenerator/list/OrderedList.java
Outdated
Show resolved
Hide resolved
...e/MarkdownGenerator/src/main/java/net/steppschuh/markdowngenerator/list/OrderedListItem.java
Show resolved
Hide resolved
Co-authored-by: Stephan Schultz <[email protected]>
…generator/list/OrderedList.java Co-authored-by: Stephan Schultz <[email protected]>
@Steppschuh |
This PR is old and probably wouldn't merge correctly. I suggest you create your own fork, introduce the changes as appropriate, and create another pull request. |
@Revxrsal |
Added 2 more components to the library which appear to be missing (???)
HyperlinkedImage
Would result in the following:
Which renders as (hover over):
Without tooltip:
Would result in the following:
Which renders as (hover over):
*Can have hyperlink as null too, with or without a tooltip*
OrderedList
Would create:
Which results in:
With builder:
Would create:
Which results into:
Let me know if anything should be changed.