Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated legacy sprite engine with latest features and fixes #333

Merged
merged 2 commits into from
May 29, 2024

Conversation

TheRoboZ
Copy link
Contributor

This implements:

  • SPR_setAlwaysAtBottom
  • SPR_setAutoAnimation
  • SPR_getAutoAnimation
  • SPR_setAnimationLoop
  • SPR_getAnimationDone

and fixes the empty frame bug in:

  • static void loadTiles(Sprite* sprite)

for the legacy sprite engine

@D0NM
Copy link
Contributor

D0NM commented May 27, 2024

COOL!
Alas, we keep using our own wrapper around the basic SGDK funcs because even now it is not enough for a beat 'em up

@TheRoboZ
Copy link
Contributor Author

Any chance of sharing the wrapper? This PR came from a plan to compare bot sprite engines for performance on r-type, if your wrapper performs even better, I'd gladly use it for an ad-hoc implementation for my engine.

@D0NM
Copy link
Contributor

D0NM commented May 27, 2024

Any chance of sharing the wrapper? This PR came from a plan to compare bot sprite engines for performance on r-type, if your wrapper performs even better, I'd gladly use it for an ad-hoc implementation for my engine.

We cannot share it (at least until Zabu is fully released). But the main thing in the wrapper is:

  • Animations have some meta data
  • Each frame animation has its own duration

inc/sprite_eng_legacy.h Outdated Show resolved Hide resolved
@TheRoboZ TheRoboZ requested a review from Stephane-D May 29, 2024 01:12
Copy link
Owner

@Stephane-D Stephane-D left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved :) Thanks for your contribution !

@Stephane-D Stephane-D merged commit 4a753de into Stephane-D:master May 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants