[Test] 투표 마감, 상세 조회 단위 테스트 추가 #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHS00
requested review from
kssumin and
jinwooseok
and removed request for
kssumin
jinwooseok
reviewed
Nov 7, 2023
| @@ -14,15 +14,13 @@ | |||
| @Service | |||
| public class GetVoteDetailService { | |||
|
|
|||
| private final VoteRepository voteJPARepository; | |||
| private final VoteRepository voteRepository; | |||
jinwooseok
reviewed
Nov 7, 2023
|
|
||
| closeVoteService.closeVote(voteId, requestUserId); | ||
| // 분 단위까지만 비교 | ||
| LocalDateTime now = LocalDateTime.now().truncatedTo(ChronoUnit.MINUTES); |
jinwooseok
reviewed
Nov 7, 2023
|
|
||
| // when & then | ||
| assertThrows(NullPointerException.class, () -> closeVoteService.closeVote(voteId, userId)); | ||
| assertThrows(NullException.class, () -> closeVoteService.closeVote(voteId, requestUserId)); |
There was a problem hiding this comment.
이거 repository를 when then return한 부분이 안보이는거같아요
jinwooseok
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
어떤 내용에 대한 PR인가요?
변경된 내용에 대한 전반적인 설명을 작성해주세요
변경 사항
변경된 부분에 대한 상세한 내용을 나열해주세요
무엇을 위주로 보면 좋을까요?
리뷰어가 어디를 집중적으로 보면 좋을 지 알려주세요!
관련된 이슈
closes (#144 )
테스트 방법
변경 사항에 대한 테스트 방법이나 확인 사항을 기술합니다.