[Enhancement] Move delta write open out of brpc worker #56517
+372
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevincai
reviewed
Mar 4, 2025
| @@ -679,11 +679,59 @@ Status LocalTabletsChannel::_open_all_writers(const PTabletWriterOpenRequest& pa | |||
| } | |||
|
|
|||
| _is_replicated_storage = params.is_replicated_storage(); | |||
| std::shared_ptr<DeltaWriterOpenContext> context = std::make_shared<DeltaWriterOpenContext>(); | |||
There was a problem hiding this comment.
we can move the execution to thread pool in the brpc entrypoint in backend_service.cpp or internal_service.cpp just like other brpc interface, e.g. exec_plan_fragment ...
Signed-off-by: PengFei Li <[email protected]>
Signed-off-by: PengFei Li <[email protected]>
banmoy
changed the title
kevincai
reviewed
Mar 5, 2025
| @@ -205,6 +205,7 @@ class StarRocksMetrics { | |||
| METRIC_DEFINE_INT_COUNTER(load_bytes_total, MetricUnit::BYTES); | |||
|
|
|||
| // Metrics for LoadChannel | |||
| METRICS_DEFINE_THREAD_POOL(load_channel_mgr); | |||
There was a problem hiding this comment.
load_channel_pool? a little confused a thread pool is named as *_mgr
| @@ -71,6 +71,14 @@ namespace lake { | |||
| class TabletManager; | |||
| } | |||
|
|
|||
| struct LoadChannelOpenRequest { | |||
There was a problem hiding this comment.
this is also the same as the RPC's controller, maybe name it LoadChannelOpenController or LoadChannelOpenContext
| return; | ||
| } | ||
| auto task = [=]() { this->_open(open_request); }; | ||
| Status status = _async_rpc_pool->submit_func(std::move(task)); |
There was a problem hiding this comment.
the task can be submit successful but not executed at all when doing pool shutdown, hence lead the done never get called and resulting the brpc server exit hanging.
Signed-off-by: PengFei Li <[email protected]>
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
tablet_writer_openbrpc request needs to initialize DeltaWriter (DeltaWriter::_init). The initialization can be heavy because it needs to hold many pthread locks, such asWaiting lock can block brpc worker and make the whole brpc service unavailable. We need move the initialization out of brpc worker so that it won't affect the brpc service.
What I'm doing:
when receiving the
tablet_writer_openrpc request, submit it to a separate thread pool to process itFixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: