Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix insert overwrite loss data since dynamic open partition (backport #55756) #55816

Merged
merged 5 commits into from
Feb 14, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Feb 11, 2025

Why I'm doing:

The insert operation from an insert overwrite job is special because the partitions it opens are temporary partitions, so all of them need to be opened in advance.

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

…55756)

Signed-off-by: meegoo <[email protected]>
(cherry picked from commit 64c8328)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/planner/OlapTableSink.java
#	fe/fe-core/src/main/java/com/starrocks/sql/InsertPlanner.java
#	fe/fe-core/src/main/java/com/starrocks/sql/ast/InsertStmt.java
@mergify mergify bot added the conflicts label Feb 11, 2025
Copy link
Contributor Author

mergify bot commented Feb 11, 2025

Cherry-pick of 64c8328 has failed:

On branch mergify/bp/branch-3.3/pr-55756
Your branch is up to date with 'origin/branch-3.3'.

You are currently cherry-picking commit 64c83285c7.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   fe/fe-core/src/main/java/com/starrocks/load/InsertOverwriteJobRunner.java
	new file:   test/sql/test_insert_overwrite/R/test_insert
	new file:   test/sql/test_insert_overwrite/T/test_insert

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   fe/fe-core/src/main/java/com/starrocks/planner/OlapTableSink.java
	both modified:   fe/fe-core/src/main/java/com/starrocks/sql/InsertPlanner.java
	both modified:   fe/fe-core/src/main/java/com/starrocks/sql/ast/InsertStmt.java

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Copy link
Contributor Author

mergify bot commented Feb 11, 2025

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr

auto-merge was automatically disabled February 11, 2025 12:29

Pull request was closed

@meegoo meegoo reopened this Feb 14, 2025
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) February 14, 2025 07:31
@meegoo meegoo disabled auto-merge February 14, 2025 07:40
@meegoo meegoo enabled auto-merge (squash) February 14, 2025 07:40
@meegoo meegoo disabled auto-merge February 14, 2025 08:07
@meegoo meegoo enabled auto-merge (squash) February 14, 2025 08:07
@meegoo meegoo merged commit 69a2c30 into branch-3.3 Feb 14, 2025
29 checks passed
@meegoo meegoo deleted the mergify/bp/branch-3.3/pr-55756 branch February 14, 2025 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant