Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Eliminate non-required unnest computation (backport #55431) #55675

Closed
wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Feb 7, 2025

Why I'm doing:

If table function result is not required to output, then it is not need to compute, instead, we just obtain the number of input param's element then duplicate the required output columns.

With this optimzation, some query can be accelerated significantly.

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Signed-off-by: satanson <[email protected]>
(cherry picked from commit 4be4b5c)

# Conflicts:
#	fe/fe-core/src/test/java/com/starrocks/sql/plan/TableFunctionTest.java
@mergify mergify bot added the conflicts label Feb 7, 2025
Copy link
Contributor Author

mergify bot commented Feb 7, 2025

Cherry-pick of 4be4b5c has failed:

On branch mergify/bp/branch-3.4/pr-55431
Your branch is up to date with 'origin/branch-3.4'.

You are currently cherry-picking commit 4be4b5c34.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   be/src/exec/pipeline/table_function_operator.cpp
	modified:   be/src/exec/pipeline/table_function_operator.h
	modified:   be/src/exprs/table_function/table_function.h
	modified:   be/src/exprs/table_function/unnest.h
	modified:   fe/fe-core/src/main/java/com/starrocks/planner/TableFunctionNode.java
	modified:   fe/fe-core/src/main/java/com/starrocks/sql/plan/PlanFragmentBuilder.java
	modified:   gensrc/thrift/PlanNodes.thrift

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   fe/fe-core/src/test/java/com/starrocks/sql/plan/TableFunctionTest.java

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@wanpengfei-git wanpengfei-git enabled auto-merge (squash) February 7, 2025 11:56
@mergify mergify bot closed this Feb 7, 2025
auto-merge was automatically disabled February 7, 2025 11:57

Pull request was closed

Copy link
Contributor Author

mergify bot commented Feb 7, 2025

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant