Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Support RESTORE_CLUSTER_SNAPSHOT env var to enter the restore cluster snapshot procedure #55664

Merged

Conversation

xiangguangyxg
Copy link
Contributor

Why I'm doing:

Injecting env var is much easier than modifying the command line options in k8s env.

What I'm doing:

Support RESTORE_CLUSTER_SNAPSHOT env var to enter the restore cluster snapshot procedure.

Fixes #53867

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

…estore cluster snapshot procedure

Signed-off-by: xiangguangyxg <[email protected]>
Copy link

sonarqubecloud bot commented Feb 7, 2025

Copy link

github-actions bot commented Feb 7, 2025

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

github-actions bot commented Feb 7, 2025

[FE Incremental Coverage Report]

fail : 1 / 5 (20.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/lake/snapshot/RestoreClusterSnapshotMgr.java 1 5 20.00% [62, 63, 64, 65]

Copy link

github-actions bot commented Feb 7, 2025

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

@andyziye andyziye merged commit 94726ee into StarRocks:main Feb 7, 2025
54 of 55 checks passed
Copy link

github-actions bot commented Feb 7, 2025

@Mergifyio backport branch-3.4

@github-actions github-actions bot removed the 3.4 label Feb 7, 2025
Copy link
Contributor

mergify bot commented Feb 7, 2025

backport branch-3.4

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Feb 7, 2025
…estore cluster snapshot procedure (#55664)

Signed-off-by: xiangguangyxg <[email protected]>
(cherry picked from commit 94726ee)
@xiangguangyxg xiangguangyxg deleted the restore_cluster_snapshot_env branch February 7, 2025 11:18
wanpengfei-git pushed a commit that referenced this pull request Feb 7, 2025
…estore cluster snapshot procedure (backport #55664) (#55671)

Co-authored-by: xiangguangyxg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

shared-data mode support backup restore though automated snapshot
5 participants