Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] add more metrics to help locate hotspot issues (backport #53490) #55644

Closed
wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Feb 7, 2025

Why I'm doing:

What I'm doing:

Add more metrics to improve the observability of the system, mainly including the following parts:

  1. add TableMetrics to observe table-level's queries and loads so that we can find hot spots
  2. add IOMetrics to observe the disk io occupied by different components.
  3. refactor the metrics related to pipeline executor: DriverExecutor of different resource groups will share global metrics, and use core local value instead of atomic variables as much as possible to reduce competition.
  4. add more metrics to ScanExecutor and DriverExecutor.

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Signed-off-by: silverbullet233 <[email protected]>
(cherry picked from commit 000cdd2)

# Conflicts:
#	be/src/exec/pipeline/pipeline_driver_poller.cpp
#	be/src/service/staros_worker.cpp
#	be/src/service/staros_worker.h
#	be/test/exec/pipeline/schedule/observer_test.cpp
@mergify mergify bot added the conflicts label Feb 7, 2025
Copy link
Contributor Author

mergify bot commented Feb 7, 2025

Cherry-pick of 000cdd2 has failed:

On branch mergify/bp/branch-3.4/pr-53490
Your branch is up to date with 'origin/branch-3.4'.

You are currently cherry-picking commit 000cdd21b.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   be/src/common/daemon.cpp
	modified:   be/src/exec/CMakeLists.txt
	modified:   be/src/exec/pipeline/pipeline_driver.cpp
	modified:   be/src/exec/pipeline/pipeline_driver.h
	modified:   be/src/exec/pipeline/pipeline_driver_executor.cpp
	modified:   be/src/exec/pipeline/pipeline_driver_executor.h
	modified:   be/src/exec/pipeline/pipeline_driver_poller.h
	modified:   be/src/exec/pipeline/pipeline_driver_queue.cpp
	modified:   be/src/exec/pipeline/pipeline_driver_queue.h
	new file:   be/src/exec/pipeline/pipeline_metrics.cpp
	new file:   be/src/exec/pipeline/pipeline_metrics.h
	modified:   be/src/exec/pipeline/scan/olap_chunk_source.cpp
	modified:   be/src/exec/pipeline/scan/olap_chunk_source.h
	modified:   be/src/exec/spill/log_block_manager.cpp
	modified:   be/src/exec/spill/serde.cpp
	modified:   be/src/exec/tablet_sink.cpp
	modified:   be/src/exec/tablet_sink.h
	modified:   be/src/exec/workgroup/pipeline_executor_set.cpp
	modified:   be/src/exec/workgroup/pipeline_executor_set.h
	modified:   be/src/exec/workgroup/scan_executor.cpp
	modified:   be/src/exec/workgroup/scan_executor.h
	modified:   be/src/exec/workgroup/work_group.cpp
	modified:   be/src/io/io_profiler.cpp
	modified:   be/src/io/io_profiler.h
	modified:   be/src/runtime/exec_env.cpp
	modified:   be/src/runtime/lake_tablets_channel.cpp
	modified:   be/src/runtime/local_tablets_channel.cpp
	modified:   be/src/runtime/tablets_channel.h
	modified:   be/src/storage/tablet.cpp
	modified:   be/src/util/CMakeLists.txt
	modified:   be/src/util/metrics.h
	modified:   be/src/util/starrocks_metrics.cpp
	modified:   be/src/util/starrocks_metrics.h
	modified:   be/src/util/system_metrics.cpp
	modified:   be/src/util/system_metrics.h
	new file:   be/src/util/table_metrics.cpp
	new file:   be/src/util/table_metrics.h
	modified:   be/test/exec/pipeline/pipeline_driver_queue_test.cpp
	modified:   be/test/exec/workgroup/pipeline_executor_set_test.cpp
	modified:   be/test/exec/workgroup/scan_task_queue_test.cpp

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	both modified:   be/src/exec/pipeline/pipeline_driver_poller.cpp
	both modified:   be/src/service/staros_worker.cpp
	both modified:   be/src/service/staros_worker.h
	deleted by us:   be/test/exec/pipeline/schedule/observer_test.cpp

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Copy link
Contributor Author

mergify bot commented Feb 7, 2025

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr

@mergify mergify bot closed this Feb 7, 2025
auto-merge was automatically disabled February 7, 2025 02:22

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant