Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Only force preagg when streaming agg has limit #55604

Merged
merged 1 commit into from
Feb 6, 2025
Merged

[BugFix] Only force preagg when streaming agg has limit #55604

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion be/src/exec/pipeline/aggregate/aggregate_distinct_streaming_sink_operator.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@

#include "runtime/current_thread.h"
#include "simd/simd.h"

namespace starrocks::pipeline {

Status AggregateDistinctStreamingSinkOperator::prepare(RuntimeState* state) {
Expand All @@ -26,7 +27,11 @@ Status AggregateDistinctStreamingSinkOperator::prepare(RuntimeState* state) {
if (_aggregator->streaming_preaggregation_mode() == TStreamingPreaggregationMode::LIMITED_MEM) {
_limited_mem_state.limited_memory_size = config::streaming_agg_limited_memory_size;
}
_aggregator->streaming_preaggregation_mode() = TStreamingPreaggregationMode::FORCE_PREAGGREGATION;
// If limit is small, streaming distinct forces pre-aggregation. After the limit is reached the operator will quickly finish.
// The limit in streaming agg is controlled by session variable: cbo_push_down_distinct_limit
if (_aggregator->limit() != -1) {
_aggregator->streaming_preaggregation_mode() = TStreamingPreaggregationMode::FORCE_PREAGGREGATION;
}
_aggregator->attach_sink_observer(state, this->_observer);
return _aggregator->open(state);
}
Expand Down
Loading