[Enhancement] adjust translate function syntax structure to prevent parser performance rollback (backport #54830) #55514
+33
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
parser performance rollback is introduced by this patch #54185
parser performance will rollback when there are many function call in query.
the parser of this case will take about 100ms.
bad case:
normal case:
What I'm doing:
Translate statement conflicts with translate function, so stripping translate function from simple function prevents performance rollback.
adjust translate function syntax structure and remove
getCharPositionInLine
fortranslate
to prevent parser performance rollback.base: 100ms
optimized: 4ms
Fixes #issue
https://github.com/StarRocks/StarRocksTest/issues/8932#issuecomment-2572967332
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist: