Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] enhance delete pruning for all kinds of partitions #55400

Merged
merged 2 commits into from
Jan 26, 2025
Merged

[Enhancement] enhance delete pruning for all kinds of partitions #55400

merged 2 commits into from
Jan 26, 2025
+125 −189

Conversation

murphyatwork
Copy link
Contributor

@murphyatwork murphyatwork commented Jan 24, 2025 •
edited
Loading

Why I'm doing:

What I'm doing:

Currently DELETE cannot do partition pruning for LIST PARTITION, which will affect many aspects, like statistics collection and materialized view refresh.

To address this issue we'd better leveraging the optimizer to do this work.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

@murphyatwork murphyatwork requested a review from a team as a code owner January 24, 2025 06:29
Seaven
Seaven previously approved these changes Jan 24, 2025
View reviewed changes
kangkaisen
kangkaisen previously approved these changes Jan 24, 2025
View reviewed changes
@murphyatwork
add test
521e73a 
Signed-off-by: Murphy <[email protected]>
@murphyatwork murphyatwork dismissed stale reviews from kangkaisen and Seaven via 521e73a January 26, 2025 04:21
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
7 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions GitHub Actions
Copy link

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 21 / 25 (84.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/load/DeleteMgr.java 21 25 84.00% [233, 235, 236, 237]

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@murphyatwork murphyatwork enabled auto-merge (squash) January 26, 2025 11:46
@murphyatwork murphyatwork merged commit 4ae63bd into StarRocks:main Jan 26, 2025
48 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.4

@github-actions github-actions bot removed the 3.4 label Jan 26, 2025
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Jan 26, 2025
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Jan 26, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 26, 2025 •
edited
Loading

backport branch-3.4

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 26, 2025 •
edited
Loading

backport branch-3.3

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 26, 2025 •
edited
Loading

backport branch-3.2

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jan 26, 2025
@murphyatwork @mergify
[Enhancement] enhance delete pruning for all kinds of partitions (#55400
e213504 
)

Signed-off-by: Murphy <[email protected]>
(cherry picked from commit 4ae63bd)
@mergify mergify bot mentioned this pull request Jan 26, 2025
Merged
18 tasks
mergify bot pushed a commit that referenced this pull request Jan 26, 2025
@murphyatwork @mergify
[Enhancement] enhance delete pruning for all kinds of partitions (#55400
00f4708 
)

Signed-off-by: Murphy <[email protected]>
(cherry picked from commit 4ae63bd)

# Conflicts:
#	fe/fe-core/src/test/java/com/starrocks/load/DeletePruneTest.java
@mergify mergify bot mentioned this pull request Jan 26, 2025
Merged
18 tasks
mergify bot pushed a commit that referenced this pull request Jan 26, 2025
@murphyatwork @mergify
[Enhancement] enhance delete pruning for all kinds of partitions (#55400
30af703 
)

Signed-off-by: Murphy <[email protected]>
(cherry picked from commit 4ae63bd)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/load/DeleteMgr.java
#	fe/fe-core/src/test/java/com/starrocks/load/DeletePruneTest.java
@mergify mergify bot mentioned this pull request Jan 26, 2025
Merged
18 tasks
murphyatwork added a commit that referenced this pull request Jan 27, 2025
@murphyatwork
[Enhancement] enhance delete pruning for all kinds of partitions (#55400
06d08bc 
)

Signed-off-by: Murphy <[email protected]>
(cherry picked from commit 4ae63bd)
Signed-off-by: Murphy <[email protected]>

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/load/DeleteMgr.java
#	fe/fe-core/src/test/java/com/starrocks/load/DeletePruneTest.java
murphyatwork added a commit that referenced this pull request Jan 27, 2025
@murphyatwork
[Enhancement] enhance delete pruning for all kinds of partitions (#55400
439a26c 
)

Signed-off-by: Murphy <[email protected]>
(cherry picked from commit 4ae63bd)
Signed-off-by: Murphy <[email protected]>

# Conflicts:
#	fe/fe-core/src/test/java/com/starrocks/load/DeletePruneTest.java
wanpengfei-git pushed a commit that referenced this pull request Jan 27, 2025
@mergify @murphyatwork
[Enhancement] enhance delete pruning for all kinds of partitions (bac…
67a367d 
…kport #55400) (#55465)

Co-authored-by: Murphy <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Jan 27, 2025
@mergify @murphyatwork
[Enhancement] enhance delete pruning for all kinds of partitions (bac…
7e755f3 
…kport #55400) (#55464)

Co-authored-by: Murphy <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Jan 27, 2025
@mergify @murphyatwork
[Enhancement] enhance delete pruning for all kinds of partitions (bac…
530bde8 
…kport #55400) (#55463)

Co-authored-by: Murphy <[email protected]>
@murphyatwork murphyatwork mentioned this pull request Feb 8, 2025
Open
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@starrocks-cr starrocks-cr[bot] starrocks-cr[bot] left review comments

@wyb wyb wyb approved these changes

@Seaven Seaven Seaven approved these changes

@kangkaisen kangkaisen kangkaisen left review comments

Assignees

@murphyatwork murphyatwork

Labels
3.2-merged 3.3-merged 3.4-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@murphyatwork @wyb @Seaven @kangkaisen