[Feature] Support Mysql Field function #55331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Wenjun7J
changed the title
github-actions
bot
added
the
documentation
Wenjun7J
force-pushed
the
support_field_function
branch
from
90206a8 to
9ed76ac
Compare
Seaven
reviewed
Jan 22, 2025
| @@ -806,6 +807,45 @@ private static Function getAdjustedAnalyzedFunction(ConnectContext session, | |||
| break; | |||
| } | |||
| } | |||
| } else if (FunctionSet.FIELD.equalsIgnoreCase(fnName)) { | |||
There was a problem hiding this comment.
I think don't need this change, could be ref greatest function
There was a problem hiding this comment.
The goal here is to make the FIELD function compatible with MySQL’s parameter type inference behavior. The default choice of function signature would otherwise lead to inconsistent behavior.
trueeyu
reviewed
Jan 23, 2025
trueeyu
reviewed
Jan 23, 2025
trueeyu
reviewed
Jan 23, 2025
trueeyu
reviewed
Jan 23, 2025
Wenjun7J
force-pushed
the
support_field_function
branch
from
9ed76ac to
4656202
Compare
trueeyu
reviewed
Feb 5, 2025
trueeyu
reviewed
Feb 5, 2025
| (targetType.isStringType() && argumentTypes[i].isStringType())) { | ||
| targetType = Type.getAssignmentCompatibleType(targetType, argumentTypes[i], false); | ||
| if (targetType.isInvalid()) { | ||
| throw new SemanticException("Parameter's type is not invalid"); |
There was a problem hiding this comment.
is not invalid or is invalid?
There was a problem hiding this comment.
Revised as is invalid
trueeyu
reviewed
Feb 5, 2025
be/src/exprs/string_functions.h
Outdated
| result.append(0); | ||
| return result.build(true); | ||
| } else if (state != nullptr) { | ||
| LOG(WARNING) << "state:" << state->all_const << " " << state->list_all_const << std::endl; |
Seaven
previously approved these changes
Feb 5, 2025
trueeyu
previously approved these changes
Feb 6, 2025
Seaven
previously approved these changes
Feb 6, 2025
HangyuanLiu
previously approved these changes
Feb 6, 2025
wangsimo0
previously approved these changes
Feb 6, 2025
1 task
Wenjun7J
force-pushed
the
support_field_function
branch
from
91da794 to
7ad7705
Compare
Wenjun7J
dismissed stale reviews from Seaven, trueeyu, HangyuanLiu, and wangsimo0
via
66d5dcc
Wenjun7J
force-pushed
the
support_field_function
branch
4 times, most recently
from
3416d97 to
98d2fc0
Compare
Signed-off-by: SevenJ <[email protected]>
Wenjun7J
force-pushed
the
support_field_function
branch
from
98d2fc0 to
0c54136
Compare
Signed-off-by: SevenJ <[email protected]>
Wenjun7J
force-pushed
the
support_field_function
branch
3 times, most recently
from
508aab5 to
0648036
Compare
Signed-off-by: SevenJ <[email protected]>
Wenjun7J
force-pushed
the
support_field_function
branch
from
0648036 to
fae4205
Compare
|
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 34 / 35 (97.14%) file detail
|
[BE Incremental Coverage Report]❌ fail : 0 / 63 (00.00%) file detail
|
trueeyu
approved these changes
Feb 7, 2025
HangyuanLiu
approved these changes
Feb 7, 2025
wangsimo0
approved these changes
Feb 7, 2025
Seaven
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
For custom sorting.
What I'm doing:
Implement field function. Fixes #55585
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: