[BugFix] Fix shared UDF concurrent load issue #54779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stdpain
previously approved these changes
Jan 7, 2025
stdpain
reviewed
Jan 8, 2025
| @@ -262,7 +262,9 @@ Status UserFunctionCache::_load_cache_entry(const std::string& url, UserFunction | |||
| RETURN_IF_ERROR(_download_lib(url, entry)); | |||
| } | |||
|
|
|||
| RETURN_IF_ERROR(_load_cache_entry_internal(url, entry, loader)); | |||
| if (!entry->is_loaded.load()) { | |||
| RETURN_IF_ERROR(_load_cache_entry_internal(entry, loader)); | |||
There was a problem hiding this comment.
Suggested change
| RETURN_IF_ERROR(_load_cache_entry_internal(entry, loader)); | |
| RETURN_IF_ERROR(_load_cache_entry_internal(url, entry, loader)); |
Signed-off-by: ganggewang <[email protected]>
Signed-off-by: ganggewang <[email protected]>
wangshisan
force-pushed
the
fix_concurrent_udf_load
branch
from
a39df69 to
359231c
Compare
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]✅ pass : 2 / 2 (100.00%) file detail
|
stdpain
approved these changes
Jan 20, 2025
Seaven
approved these changes
Jan 20, 2025
|
@Mergifyio backport branch-3.4 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jan 20, 2025
Signed-off-by: ganggewang <[email protected]> (cherry picked from commit f451b65)
18 tasks
wanpengfei-git
pushed a commit
that referenced
this pull request
Feb 14, 2025
Co-authored-by: wangshisan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
If a UDF is created with SHARED mode, suppose the UDF packages would be load only once in a single BE process. While, there is a concurrent issue int the current implementation, which may result in that a shared UDF may be load multiple times when there are concurrent UDF calls.
What I'm doing:
Fixes the concurrent issue, check if the UDF has already been load before load it.
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: