Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Support fe starting with only image no bdb log #54514

Merged
merged 1 commit into from
Dec 31, 2024
Merged

[Enhancement] Support fe starting with only image no bdb log #54514

merged 1 commit into from
Dec 31, 2024

Conversation

xiangguangyxg
Copy link
Contributor

@xiangguangyxg xiangguangyxg commented Dec 30, 2024 •
edited
Loading

Why I'm doing:

When there is only image no bdb log, fe will start failed.

What I'm doing:

Support fe starting with only image no bdb log.

Fixes #53867

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

@xiangguangyxg xiangguangyxg requested a review from a team as a code owner December 30, 2024 12:33
@github-actions github-actions bot added the 3.4 label Dec 30, 2024
@github-actions github-actions bot added the 3.3 label Dec 31, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions GitHub Actions
Copy link

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

❌ fail : 9 / 13 (69.23%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/journal/bdbje/BDBEnvironment.java 4 8 50.00% [185, 186, 188, 189]
🔵 com/starrocks/server/GlobalStateMgr.java 1 1 100.00% []
🔵 com/starrocks/server/NodeMgr.java 4 4 100.00% []

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@andyziye andyziye merged commit d1c3335 into StarRocks:main Dec 31, 2024
68 of 69 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.4

@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.3

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 31, 2024 •
edited
Loading

backport branch-3.4

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 31, 2024 •
edited
Loading

backport branch-3.3

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Dec 31, 2024
@xiangguangyxg @mergify
[Enhancement] Support fe starting with only image no bdb log (#54514)
7a5da3c 
Signed-off-by: xiangguangyxg <[email protected]>
(cherry picked from commit d1c3335)
@mergify mergify bot mentioned this pull request Dec 31, 2024
Merged
18 tasks
mergify bot pushed a commit that referenced this pull request Dec 31, 2024
@xiangguangyxg @mergify
[Enhancement] Support fe starting with only image no bdb log (#54514)
811f8b8 
Signed-off-by: xiangguangyxg <[email protected]>
(cherry picked from commit d1c3335)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/server/GlobalStateMgr.java
@mergify mergify bot mentioned this pull request Dec 31, 2024
Merged
18 tasks
wanpengfei-git pushed a commit that referenced this pull request Dec 31, 2024
@mergify @xiangguangyxg
[Enhancement] Support fe starting with only image no bdb log (backport …
8f16a92 
…#54514) (#54548)

Signed-off-by: xiangguangyxg <[email protected]>
Co-authored-by: xiangguangyxg <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Dec 31, 2024
@mergify @xiangguangyxg
[Enhancement] Support fe starting with only image no bdb log (backport …
8d5bed9 
…#54514) (#54549)

Signed-off-by: xiangguangyxg <[email protected]>
Co-authored-by: xiangguangyxg <[email protected]>
@xiangguangyxg xiangguangyxg deleted the fix_no_bdb branch January 1, 2025 14:00
maggie-zhu pushed a commit to maggie-zhu/starrocks that referenced this pull request Jan 6, 2025
@xiangguangyxg
[Enhancement] Support fe starting with only image no bdb log (StarRoc…
ed876ff 
…ks#54514)

Signed-off-by: xiangguangyxg <[email protected]>
zhangyifan27 pushed a commit to zhangyifan27/starrocks that referenced this pull request Feb 10, 2025
@mergify @xiangguangyxg
[Enhancement] Support fe starting with only image no bdb log (backport …
0cd284f 
…StarRocks#54514) (StarRocks#54549)

Signed-off-by: xiangguangyxg <[email protected]>
Co-authored-by: xiangguangyxg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevincai kevincai kevincai approved these changes

@gengjun-git gengjun-git gengjun-git approved these changes

Assignees

@xiangguangyxg xiangguangyxg

Labels
3.3-merged 3.4-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

shared-data mode support backup restore though automated snapshot
4 participants
@xiangguangyxg @kevincai @gengjun-git @andyziye