[BugFix] Use a separate thread pool for dictionary collection #54454

stdpain · 2024-12-27T08:04:03Z

Why I'm doing:

Use a separate dictionary to avoid occupying the default ForkJoinPool leading to potential deadlocks.

What I'm doing:

Fixes #issue

What type of PR is this:

Does this PR entail a change in behavior?

Yes, this PR will result in a change in behavior.
No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

Interface/UI changes: syntax, type conversion, expression evaluation, display information
Parameter changes: default values, similar parameters but with different default values
Policy changes: use new policy to replace old one, functionality automatically enabled
Feature removed
Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

I have added test cases for my bug fix or my new feature
This pr needs user documentation (for new or modified features or behaviors)
- I have added documentation for my new feature or new function
This is a backport pr

Bugfix cherry-pick branch check:

Use a separate dictionary to avoid occupying the default ForkJoinPool leading to potential deadlocks. Signed-off-by: stdpain <[email protected]>

sonarqubecloud · 2024-12-27T09:02:38Z

Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

github-actions · 2024-12-27T10:32:19Z

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

github-actions · 2024-12-27T10:32:56Z

[FE Incremental Coverage Report]

✅ pass : 3 / 3 (100.00%)

file detail

	path	covered_line	new_line	coverage	not_covered_line_detail
🔵	com/starrocks/common/Config.java	1	1	100.00%	[]
🔵	com/starrocks/sql/optimizer/statistics/CacheDictManager.java	2	2	100.00%	[]

github-actions · 2024-12-27T10:33:11Z

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

github-actions · 2024-12-30T12:27:31Z

@Mergifyio backport branch-3.4

github-actions · 2024-12-30T12:27:33Z

@Mergifyio backport branch-3.3

github-actions · 2024-12-30T12:27:34Z

@Mergifyio backport branch-3.2

github-actions · 2024-12-30T12:27:35Z

@Mergifyio backport branch-3.1

mergify · 2024-12-30T12:27:55Z

backport branch-3.4

✅ Backports have been created

#54510 [BugFix] Use a separate thread pool for dictionary collection (backport #54454) has been created for branch branch-3.4

mergify · 2024-12-30T12:27:56Z

backport branch-3.3

✅ Backports have been created

#54511 [BugFix] Use a separate thread pool for dictionary collection (backport #54454) has been created for branch branch-3.3

mergify · 2024-12-30T12:27:58Z

backport branch-3.2

✅ Backports have been created

#54512 [BugFix] Use a separate thread pool for dictionary collection (backport #54454) has been created for branch branch-3.2

mergify · 2024-12-30T12:27:59Z

backport branch-3.1

✅ Backports have been created

#54513 [BugFix] Use a separate thread pool for dictionary collection (backport #54454) has been created for branch branch-3.1

Signed-off-by: stdpain <[email protected]> (cherry picked from commit 9a6445a)

#54454) (#54510) Signed-off-by: stdpain <[email protected]> Co-authored-by: stdpain <[email protected]>

#54454) (#54511) Co-authored-by: stdpain <[email protected]>

#54454) (#54513) Signed-off-by: stdpain <[email protected]> Co-authored-by: stdpain <[email protected]>

#54454) (#54512) Signed-off-by: stdpain <[email protected]> Co-authored-by: stdpain <[email protected]>

…cks#54454) Signed-off-by: stdpain <[email protected]>

StarRocks#54454) (StarRocks#54511) Co-authored-by: stdpain <[email protected]>

stdpain requested a review from a team as a code owner December 27, 2024 08:04

github-actions bot added 3.4 3.3 3.2 3.1 labels Dec 27, 2024

mergify bot assigned stdpain Dec 27, 2024

[BugFix] Use a separate thread pool for dictionary collection

6809b6b

Use a separate dictionary to avoid occupying the default ForkJoinPool leading to potential deadlocks. Signed-off-by: stdpain <[email protected]>

stdpain force-pushed the use_separate_thread_pool_for_dict branch 2 times, most recently from aa66bfe to 6809b6b Compare December 27, 2024 08:55

kevincai approved these changes Dec 27, 2024

View reviewed changes

trueeyu approved these changes Dec 30, 2024

View reviewed changes

Seaven approved these changes Dec 30, 2024

View reviewed changes

stdpain merged commit 9a6445a into StarRocks:main Dec 30, 2024
64 of 66 checks passed

github-actions bot removed the 3.4 label Dec 30, 2024

github-actions bot removed the 3.3 label Dec 30, 2024

github-actions bot removed 3.2 3.1 labels Dec 30, 2024

mergify bot pushed a commit that referenced this pull request Dec 30, 2024

[BugFix] Use a separate thread pool for dictionary collection (#54454)

9877f72

Signed-off-by: stdpain <[email protected]> (cherry picked from commit 9a6445a)

mergify bot mentioned this pull request Dec 30, 2024

[BugFix] Use a separate thread pool for dictionary collection (backport #54454) #54510

Merged

18 tasks

mergify bot pushed a commit that referenced this pull request Dec 30, 2024

[BugFix] Use a separate thread pool for dictionary collection (#54454)

859c8af

Signed-off-by: stdpain <[email protected]> (cherry picked from commit 9a6445a)

mergify bot mentioned this pull request Dec 30, 2024

[BugFix] Use a separate thread pool for dictionary collection (backport #54454) #54511

Merged

18 tasks

mergify bot pushed a commit that referenced this pull request Dec 30, 2024

[BugFix] Use a separate thread pool for dictionary collection (#54454)

ebabb78

Signed-off-by: stdpain <[email protected]> (cherry picked from commit 9a6445a)

mergify bot mentioned this pull request Dec 30, 2024

[BugFix] Use a separate thread pool for dictionary collection (backport #54454) #54512

Merged

18 tasks

mergify bot pushed a commit that referenced this pull request Dec 30, 2024

[BugFix] Use a separate thread pool for dictionary collection (#54454)

2492bf3

Signed-off-by: stdpain <[email protected]> (cherry picked from commit 9a6445a)

mergify bot mentioned this pull request Dec 30, 2024

[BugFix] Use a separate thread pool for dictionary collection (backport #54454) #54513

Merged

18 tasks

wanpengfei-git pushed a commit that referenced this pull request Dec 31, 2024

[BugFix] Use a separate thread pool for dictionary collection (backport

a18d85a

#54454) (#54510) Signed-off-by: stdpain <[email protected]> Co-authored-by: stdpain <[email protected]>

github-actions bot added the 3.4-merged label Dec 31, 2024

wanpengfei-git pushed a commit that referenced this pull request Dec 31, 2024

[BugFix] Use a separate thread pool for dictionary collection (backport

c339943

#54454) (#54511) Co-authored-by: stdpain <[email protected]>

github-actions bot added the 3.3-merged label Dec 31, 2024

wanpengfei-git pushed a commit that referenced this pull request Dec 31, 2024

[BugFix] Use a separate thread pool for dictionary collection (backport

8b431fe

#54454) (#54513) Signed-off-by: stdpain <[email protected]> Co-authored-by: stdpain <[email protected]>

github-actions bot added the 3.1-merged label Dec 31, 2024

wanpengfei-git pushed a commit that referenced this pull request Dec 31, 2024

[BugFix] Use a separate thread pool for dictionary collection (backport

33025e3

#54454) (#54512) Signed-off-by: stdpain <[email protected]> Co-authored-by: stdpain <[email protected]>

github-actions bot added the 3.2-merged label Dec 31, 2024

maggie-zhu pushed a commit to maggie-zhu/starrocks that referenced this pull request Jan 6, 2025

[BugFix] Use a separate thread pool for dictionary collection (StarRo…

63e31d0

…cks#54454) Signed-off-by: stdpain <[email protected]>

zhangyifan27 pushed a commit to zhangyifan27/starrocks that referenced this pull request Feb 10, 2025

[BugFix] Use a separate thread pool for dictionary collection (backport

6e555f7

StarRocks#54454) (StarRocks#54511) Co-authored-by: stdpain <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[BugFix] Use a separate thread pool for dictionary collection #54454

[BugFix] Use a separate thread pool for dictionary collection #54454

stdpain commented Dec 27, 2024 •

edited

Loading

sonarqubecloud bot commented Dec 27, 2024

github-actions bot commented Dec 27, 2024

github-actions bot commented Dec 27, 2024

github-actions bot commented Dec 27, 2024

github-actions bot commented Dec 30, 2024

github-actions bot commented Dec 30, 2024

github-actions bot commented Dec 30, 2024

github-actions bot commented Dec 30, 2024

mergify bot commented Dec 30, 2024 •

edited

Loading

mergify bot commented Dec 30, 2024 •

edited

Loading

mergify bot commented Dec 30, 2024 •

edited

Loading

mergify bot commented Dec 30, 2024 •

edited

Loading

[BugFix] Use a separate thread pool for dictionary collection #54454

[BugFix] Use a separate thread pool for dictionary collection #54454

Conversation

stdpain commented Dec 27, 2024 • edited Loading

Why I'm doing:

What I'm doing:

What type of PR is this:

Checklist:

Bugfix cherry-pick branch check:

sonarqubecloud bot commented Dec 27, 2024

Quality Gate failed

github-actions bot commented Dec 27, 2024

[Java-Extensions Incremental Coverage Report]

github-actions bot commented Dec 27, 2024

[FE Incremental Coverage Report]

file detail

github-actions bot commented Dec 27, 2024

[BE Incremental Coverage Report]

github-actions bot commented Dec 30, 2024

github-actions bot commented Dec 30, 2024

github-actions bot commented Dec 30, 2024

github-actions bot commented Dec 30, 2024

mergify bot commented Dec 30, 2024 • edited Loading

✅ Backports have been created

mergify bot commented Dec 30, 2024 • edited Loading

✅ Backports have been created

mergify bot commented Dec 30, 2024 • edited Loading

✅ Backports have been created

mergify bot commented Dec 30, 2024 • edited Loading

✅ Backports have been created

stdpain commented Dec 27, 2024 •

edited

Loading

mergify bot commented Dec 30, 2024 •

edited

Loading

mergify bot commented Dec 30, 2024 •

edited

Loading

mergify bot commented Dec 30, 2024 •

edited

Loading

mergify bot commented Dec 30, 2024 •

edited

Loading