[BugFix] Optimize merge commit performance (backport #54251) #54443
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
Optimize the performance of merge commit under high pressure load
What I'm doing:
butil::ip2str
to get the ip of the client rather thanbutil::ip2hostname
.ip2hostname
may communicate with DNS server which causes second-level latency jitter. See BatchWriteMgr::receive_stream_load_rpcIOTaskWaitTime
is large. So adjust the time from 50ms to 500us. 500us is an empirical value under the high concurrency load. After the pipeline engine supports event-based scheduling, we can reimplement it with the input-driven instead of polling. See BatchWriteMgr::create_and_register_pipeFixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist: