[Enhancement] Correct fe node name if needed when fe start with bdbje_reset_election_group #54399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_reset_election_group Signed-off-by: xiangguangyxg <[email protected]>
![starrocks-cr[bot]](https://avatars.githubusercontent.com/in/404334?s=60&v=4){kind=small}
|
HangyuanLiu
approved these changes
Dec 26, 2024
gengjun-git
approved these changes
Dec 26, 2024
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]❌ fail : 5 / 16 (31.25%) file detail
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
|
@Mergifyio backport branch-3.4 |
|
@Mergifyio backport branch-3.3 |
✅ Backports have been created
|
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Dec 27, 2024
…_reset_election_group (#54399) Signed-off-by: xiangguangyxg <[email protected]> (cherry picked from commit 34776d2)
mergify bot
pushed a commit
that referenced
this pull request
Dec 27, 2024
…_reset_election_group (#54399) Signed-off-by: xiangguangyxg <[email protected]> (cherry picked from commit 34776d2)
wanpengfei-git
pushed a commit
that referenced
this pull request
Dec 27, 2024
…_reset_election_group (backport #54399) (#54436) Co-authored-by: xiangguangyxg <[email protected]>
wanpengfei-git
pushed a commit
that referenced
this pull request
Dec 27, 2024
…_reset_election_group (backport #54399) (#54437) Co-authored-by: xiangguangyxg <[email protected]>
maggie-zhu
pushed a commit
to maggie-zhu/starrocks
that referenced
this pull request
Jan 6, 2025
…_reset_election_group (StarRocks#54399) Signed-off-by: xiangguangyxg <[email protected]>
zhangyifan27
pushed a commit
to zhangyifan27/starrocks
that referenced
this pull request
Feb 10, 2025
…_reset_election_group (backport StarRocks#54399) (StarRocks#54437) Co-authored-by: xiangguangyxg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
When fe starts from a image dir copied from another node using bdbje_reset_election_group, the node name will be wrong, may confuse users.
What I'm doing:
Correct fe node name if needed when fe start with bdbje_reset_election_group.
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: