Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] improve performance of show materialized views statement #54374

Merged
merged 2 commits into from
Dec 30, 2024

Conversation

murphyatwork
Copy link
Contributor

@murphyatwork murphyatwork commented Dec 26, 2024

Why I'm doing:

What I'm doing:

When executing SHOW MATERIALIZED VIEWS, it is necessary to check the status of the last job.

Currently, we retrieve all historical records for a materialized view (MV), which can be slow when there are many entries. To improve performance, we now only query the records for the most recent job.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

@murphyatwork murphyatwork force-pushed the murphy_opt_mv_list_task_runs branch from ff484b6 to b309d0c Compare December 26, 2024 06:47
@github-actions github-actions bot removed the 3.2 label Dec 26, 2024
@murphyatwork murphyatwork changed the title [Enhancement] lookup only the last job but not all records to improve performance [Enhancement] improve performance of show materialized views statement Dec 26, 2024
@murphyatwork murphyatwork enabled auto-merge (squash) December 26, 2024 10:44
satanson
satanson previously approved these changes Dec 26, 2024
@murphyatwork murphyatwork dismissed stale reviews from LiShuMing and satanson via fe7cd4e December 27, 2024 08:07
Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

fail : 8 / 26 (30.77%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/scheduler/history/TaskRunHistoryTable.java 2 19 10.53% [241, 261, 262, 263, 264, 266, 267, 268, 270, 272, 273, 274, 276, 277, 278, 280, 281]
🔵 com/starrocks/scheduler/history/TaskRunHistory.java 5 6 83.33% [116]
🔵 com/starrocks/scheduler/TaskManager.java 1 1 100.00% []

Copy link

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

@kangkaisen kangkaisen disabled auto-merge December 30, 2024 06:42
@kangkaisen kangkaisen merged commit c70eadf into StarRocks:main Dec 30, 2024
50 of 51 checks passed
Copy link

@Mergifyio backport branch-3.4

@github-actions github-actions bot removed the 3.4 label Dec 30, 2024
Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Dec 30, 2024
Copy link
Contributor

mergify bot commented Dec 30, 2024

backport branch-3.4

✅ Backports have been created

Copy link
Contributor

mergify bot commented Dec 30, 2024

backport branch-3.3

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Dec 30, 2024
mergify bot pushed a commit that referenced this pull request Dec 30, 2024
#54374)

Signed-off-by: Murphy <[email protected]>
(cherry picked from commit c70eadf)

# Conflicts:
#	test/sql/test_materialized_view/R/test_show_materialized_view
#	test/sql/test_materialized_view/T/test_show_materialized_view
maggie-zhu pushed a commit to maggie-zhu/starrocks that referenced this pull request Jan 6, 2025
wanpengfei-git pushed a commit that referenced this pull request Jan 7, 2025
@wangsimo0
Copy link
Contributor

ignore backport check:3.3.9

murphyatwork added a commit that referenced this pull request Feb 6, 2025
wanpengfei-git pushed a commit that referenced this pull request Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants