Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Add ColumnAndPredicate #53635

Merged
merged 1 commit into from
Dec 6, 2024
Merged

[Enhancement] Add ColumnAndPredicate #53635

merged 1 commit into from
Dec 6, 2024

Conversation

trueeyu
Copy link
Contributor

@trueeyu trueeyu commented Dec 6, 2024 •
edited
Loading

Why I'm doing:

Later storage engine will dynamic transfer runtime filter(min=5, max=10, has_null) to (xxx>=5 and xxx<10) or (xxx has null) , so i need support ColumnAndPredicate first.

What I'm doing:

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

@trueeyu
Add ColumnAndPredicate
88cf5f4 
Signed-off-by: trueeyu <[email protected]>
@mergify mergify bot assigned trueeyu Dec 6, 2024
@trueeyu trueeyu marked this pull request as ready for review December 6, 2024 02:53
@trueeyu trueeyu requested review from a team as code owners December 6, 2024 02:53
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2024

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2024

[FE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2024

[BE Incremental Coverage Report]

✅ pass : 51 / 56 (91.07%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/storage/column_and_predicate.h 1 6 16.67% [40, 43, 44, 45, 46]
🔵 be/src/storage/column_and_predicate.cpp 40 40 100.00% []
🔵 be/src/storage/column_or_predicate.cpp 10 10 100.00% []

@wyb wyb merged commit 13ddfe2 into StarRocks:main Dec 6, 2024
61 checks passed
@trueeyu
Copy link
Contributor Author

trueeyu commented Dec 25, 2024

@Mergifyio backport branch-3.4 branch-3.4.0-rc01

@github-actions github-actions bot added the 3.4 label Dec 25, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 25, 2024 •
edited
Loading

backport branch-3.4 branch-3.4.0-rc01

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Dec 25, 2024
@trueeyu @mergify
[Enhancement] Add ColumnAndPredicate (#53635)
853be7d 
Signed-off-by: trueeyu <[email protected]>
(cherry picked from commit 13ddfe2)
mergify bot pushed a commit that referenced this pull request Dec 25, 2024
@trueeyu @mergify
[Enhancement] Add ColumnAndPredicate (#53635)
e06d3c2 
Signed-off-by: trueeyu <[email protected]>
(cherry picked from commit 13ddfe2)
This was referenced Dec 25, 2024
Merged
Merged
wanpengfei-git pushed a commit that referenced this pull request Dec 25, 2024
@mergify @trueeyu
[Enhancement] Add ColumnAndPredicate (backport #53635) (#54345)
d9d1fd1 
Co-authored-by: trueeyu <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Dec 25, 2024
@mergify @trueeyu
[Enhancement] Add ColumnAndPredicate (backport #53635) (#54344)
34e57b2 
Co-authored-by: trueeyu <[email protected]>
@trueeyu
Copy link
Contributor Author

trueeyu commented Jan 9, 2025

https://github.com/Mergifyio backport branch-3.3

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 9, 2025 •
edited
Loading

backport branch-3.3

✅ Backports have been created

@github-actions github-actions bot added the 3.3 label Jan 9, 2025
mergify bot pushed a commit that referenced this pull request Jan 9, 2025
@trueeyu @mergify
[Enhancement] Add ColumnAndPredicate (#53635)
ffe487b 
Signed-off-by: trueeyu <[email protected]>
(cherry picked from commit 13ddfe2)

# Conflicts:
#	be/src/storage/column_in_predicate.cpp
#	be/test/CMakeLists.txt
@mergify mergify bot mentioned this pull request Jan 9, 2025
Merged
18 tasks
wanpengfei-git pushed a commit that referenced this pull request Jan 10, 2025
@mergify @trueeyu
[Enhancement] Add ColumnAndPredicate (backport #53635) (#54875)
93f7c9b 
Signed-off-by: trueeyu <[email protected]>
Co-authored-by: trueeyu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stdpain stdpain stdpain approved these changes

@wyb wyb wyb approved these changes

Assignees

@trueeyu trueeyu

Labels
3.3-merged 3.3 3.4-merged 3.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@trueeyu @wyb @stdpain