Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix]Dictionary drop operations and refresh operations collide, resulting in inconsistent metadata. #53548

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

zhangheihei
Copy link
Contributor

@zhangheihei zhangheihei commented Dec 4, 2024

Why I'm doing:

What I'm doing:

Fixes #53549

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

…esulting in inconsistent metadata.

Signed-off-by: edwinhzhang <[email protected]>
@zhangheihei zhangheihei force-pushed the bugfix-dictionary-meta branch from 502ddb4 to 44a55dc Compare December 4, 2024 09:40
Signed-off-by: edwinhzhang <[email protected]>
@zhangheihei zhangheihei force-pushed the bugfix-dictionary-meta branch from 21b03df to 83e32ba Compare December 4, 2024 09:45
@zhangheihei zhangheihei changed the title [Bugfix] Dictionary drop operations and refresh operations collide, resulting in inconsistent metadata. [BugFix]Dictionary drop operations and refresh operations collide, resulting in inconsistent metadata. Dec 4, 2024
Copy link

sonarqubecloud bot commented Dec 4, 2024

@gengjun-git
Copy link
Contributor

@stdpain PTAL

@gengjun-git
Copy link
Contributor

@srlch PTAL

Copy link

github-actions bot commented Dec 4, 2024

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

github-actions bot commented Dec 4, 2024

[FE Incremental Coverage Report]

fail : 0 / 4 (00.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/catalog/DictionaryMgr.java 0 4 00.00% [504, 505, 507, 508]

Copy link

github-actions bot commented Dec 4, 2024

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

@alvin-celerdata alvin-celerdata merged commit c5f5b91 into StarRocks:main Dec 5, 2024
61 of 63 checks passed
Copy link

github-actions bot commented Dec 5, 2024

@Mergifyio backport branch-3.4

@github-actions github-actions bot removed the 3.4 label Dec 5, 2024
Copy link

github-actions bot commented Dec 5, 2024

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Dec 5, 2024
Copy link
Contributor

mergify bot commented Dec 5, 2024

backport branch-3.4

✅ Backports have been created

Copy link
Contributor

mergify bot commented Dec 5, 2024

backport branch-3.3

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Dec 5, 2024
…sulting in inconsistent metadata. (#53548)

Signed-off-by: edwinhzhang <[email protected]>
(cherry picked from commit c5f5b91)
mergify bot pushed a commit that referenced this pull request Dec 5, 2024
…sulting in inconsistent metadata. (#53548)

Signed-off-by: edwinhzhang <[email protected]>
(cherry picked from commit c5f5b91)
andyziye pushed a commit that referenced this pull request Dec 17, 2024
andyziye pushed a commit that referenced this pull request Dec 17, 2024
…sulting in inconsistent metadata. (#53548)

Signed-off-by: edwinhzhang <[email protected]>
(cherry picked from commit c5f5b91)
wanpengfei-git pushed a commit that referenced this pull request Dec 17, 2024
…sulting in inconsistent metadata. (backport #53548) (#53569)

Co-authored-by: zhanghe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dictionary drop operations and refresh operations collide, resulting in inconsistent metadata.
5 participants