Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Cases with only one-stage local agg don't need to be processed #53534

Conversation

stephen-shelby
Copy link
Contributor

@stephen-shelby stephen-shelby commented Dec 4, 2024

Why I'm doing:

Currently we are not adapt to the case when there is only one-stage local agg. This case should be banned first.

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

Copy link

sonarqubecloud bot commented Dec 4, 2024

Copy link

github-actions bot commented Dec 4, 2024

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

github-actions bot commented Dec 4, 2024

[FE Incremental Coverage Report]

pass : 1 / 1 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/qe/feedback/skeleton/SkeletonBuilder.java 1 1 100.00% []

Copy link

github-actions bot commented Dec 4, 2024

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

@stephen-shelby stephen-shelby merged commit 6fca3c1 into StarRocks:main Dec 4, 2024
77 of 82 checks passed
@stephen-shelby stephen-shelby deleted the fix_one_stage_local_agg_feedback branch December 4, 2024 16:00
Copy link

github-actions bot commented Dec 4, 2024

@Mergifyio backport branch-3.4

@github-actions github-actions bot removed the 3.4 label Dec 4, 2024
Copy link
Contributor

mergify bot commented Dec 4, 2024

backport branch-3.4

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Dec 4, 2024
wanpengfei-git pushed a commit that referenced this pull request Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants