-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BugFix] Cases with only one-stage local agg don't need to be processed #53534
Merged
stephen-shelby
merged 1 commit into
StarRocks:main
from
stephen-shelby:fix_one_stage_local_agg_feedback
Dec 4, 2024
Merged
[BugFix] Cases with only one-stage local agg don't need to be processed #53534
stephen-shelby
merged 1 commit into
StarRocks:main
from
stephen-shelby:fix_one_stage_local_agg_feedback
Dec 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: stephen <[email protected]>
|
kangkaisen
approved these changes
Dec 4, 2024
Seaven
approved these changes
Dec 4, 2024
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 1 / 1 (100.00%) file detail
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
@Mergifyio backport branch-3.4 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Dec 4, 2024
…ed (#53534) Signed-off-by: stephen <[email protected]> (cherry picked from commit 6fca3c1)
Merged
42 tasks
wanpengfei-git
pushed a commit
that referenced
this pull request
Dec 5, 2024
…ed (backport #53534) (#53563) Co-authored-by: stephen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
Currently we are not adapt to the case when there is only one-stage local agg. This case should be banned first.
What I'm doing:
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: