Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fix delete fail on multi level partition primary key table #53508

Merged
merged 1 commit into from
Dec 4, 2024
Merged

[BugFix] Fix delete fail on multi level partition primary key table #53508

merged 1 commit into from
Dec 4, 2024

Conversation

meegoo
Copy link
Contributor

@meegoo meegoo commented Dec 4, 2024 •
edited
Loading

Why I'm doing:

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

@meegoo meegoo requested a review from a team as a code owner December 4, 2024 00:30
@mergify mergify bot assigned meegoo Dec 4, 2024
@github-actions github-actions bot added the 3.4 label Dec 4, 2024
@meegoo meegoo force-pushed the fix_delete_multi_level branch from 5f34bd3 to a1d2a11 Compare December 4, 2024 00:43
@meegoo meegoo force-pushed the fix_delete_multi_level branch from a1d2a11 to e1a7a76 Compare December 4, 2024 04:49
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 4, 2024

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@meegoo meegoo enabled auto-merge (squash) December 4, 2024 07:30
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024

[FE Incremental Coverage Report]

✅ pass : 3 / 3 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/sql/DeletePlanner.java 1 1 100.00% []
🔵 com/starrocks/sql/analyzer/DeleteAnalyzer.java 1 1 100.00% []
🔵 com/starrocks/sql/analyzer/CreateTableAnalyzer.java 1 1 100.00% []

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@meegoo meegoo merged commit fabde4f into StarRocks:main Dec 4, 2024
48 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024

@Mergifyio backport branch-3.4

@github-actions github-actions bot removed the 3.4 label Dec 4, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 4, 2024 •
edited
Loading

backport branch-3.4

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Dec 4, 2024
@meegoo @mergify
[BugFix] Fix delete fail on multi level partition primary key table (#…
65e333a 
…53508)

Signed-off-by: meegoo <[email protected]>
(cherry picked from commit fabde4f)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/sql/DeletePlanner.java
@mergify mergify bot mentioned this pull request Dec 4, 2024
Merged
42 tasks
meegoo added a commit that referenced this pull request Dec 5, 2024
@mergify @meegoo
[BugFix] Fix delete fail on multi level partition primary key table (…
0fdea6c 
…backport #53508) (#53565)

Signed-off-by: meegoo <[email protected]>
Co-authored-by: meegoo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Seaven Seaven Seaven approved these changes

@chaoyli chaoyli chaoyli approved these changes

Assignees

@meegoo meegoo

Labels
3.4-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@meegoo @Seaven @chaoyli