[Enhancement] Support only deleting shard meta from fe for shared-data cluster #53141

wxl24life · 2024-11-22T10:08:56Z

Why I'm doing:

Add an option to delete staros meta from FE quickly

What I'm doing:

Fixes #53554

What type of PR is this:

Does this PR entail a change in behavior?

Yes, this PR will result in a change in behavior.
No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

Interface/UI changes: syntax, type conversion, expression evaluation, display information
Parameter changes: default values, similar parameters but with different default values
Policy changes: use new policy to replace old one, functionality automatically enabled
Feature removed
Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

I have added test cases for my bug fix or my new feature
This pr needs user documentation (for new or modified features or behaviors)
- I have added documentation for my new feature or new function
This is a backport pr

Bugfix cherry-pick branch check:

fe/fe-core/src/main/java/com/starrocks/lake/StarMgrMetaSyncer.java

fe/fe-core/src/test/java/com/starrocks/lake/StarMgrMetaSyncerTest.java

fe/fe-core/src/main/java/com/starrocks/lake/StarMgrMetaSyncer.java

Signed-off-by: drake_wang <[email protected]>

sonarqubecloud · 2024-12-24T09:31:13Z

Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

github-actions · 2024-12-25T03:16:47Z

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

github-actions · 2024-12-25T03:17:15Z

[FE Incremental Coverage Report]

✅ pass : 31 / 31 (100.00%)

file detail

	path	covered_line	new_line	coverage	not_covered_line_detail
🔵	com/starrocks/lake/StarMgrMetaSyncer.java	31	31	100.00%	[]

github-actions · 2024-12-25T03:18:10Z

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

github-actions · 2024-12-25T08:12:11Z

@Mergifyio backport branch-3.4

github-actions · 2024-12-25T08:12:12Z

@Mergifyio backport branch-3.3

mergify · 2024-12-25T08:12:17Z

backport branch-3.4

✅ Backports have been created

#54321 [Enhancement] Support only deleting shard meta from fe for shared-data cluster (backport #53141) has been created for branch branch-3.4

mergify · 2024-12-25T08:12:19Z

backport branch-3.3

✅ Backports have been created

#54322 [Enhancement] Support only deleting shard meta from fe for shared-data cluster (backport #53141) has been created for branch branch-3.3

…a cluster (#53141) Signed-off-by: drake_wang <[email protected]> (cherry picked from commit ffbd98b)

…a cluster (backport #53141) (#54321) Co-authored-by: Drake Wang <[email protected]>

…a cluster (backport #53141) (#54322) Co-authored-by: Drake Wang <[email protected]>

…a cluster (StarRocks#53141) Signed-off-by: drake_wang <[email protected]>

…a cluster (backport StarRocks#53141) (StarRocks#54322) Co-authored-by: Drake Wang <[email protected]>

github-actions bot added the behavior_changed label Nov 22, 2024

mergify bot assigned wxl24life Nov 22, 2024

wxl24life force-pushed the xiaolong/github-support-delete-shard-meta-only-in-fe branch from fb79562 to 95e534c Compare December 4, 2024 10:49

github-actions bot removed the behavior_changed label Dec 4, 2024

wxl24life changed the title ~~[Feature] Support only deleting shard meta from fe for shared-data cluster~~ [Enhancement] Support only deleting shard meta from fe for shared-data cluster Dec 5, 2024

github-actions bot added 3.4 3.3 labels Dec 5, 2024

wxl24life force-pushed the xiaolong/github-support-delete-shard-meta-only-in-fe branch from 95e534c to 7fbac72 Compare December 5, 2024 07:59

starrocks-xupeng approved these changes Dec 10, 2024

View reviewed changes

wxl24life force-pushed the xiaolong/github-support-delete-shard-meta-only-in-fe branch 2 times, most recently from d03c55c to 3a87ed0 Compare December 17, 2024 22:14

starrocks-xupeng reviewed Dec 18, 2024

View reviewed changes

fe/fe-core/src/main/java/com/starrocks/lake/StarMgrMetaSyncer.java Outdated Show resolved Hide resolved

starrocks-xupeng reviewed Dec 18, 2024

View reviewed changes

fe/fe-core/src/test/java/com/starrocks/lake/StarMgrMetaSyncerTest.java Outdated Show resolved Hide resolved

kevincai reviewed Dec 18, 2024

View reviewed changes

fe/fe-core/src/test/java/com/starrocks/lake/StarMgrMetaSyncerTest.java Outdated Show resolved Hide resolved

starrocks-xupeng reviewed Dec 19, 2024

View reviewed changes

fe/fe-core/src/main/java/com/starrocks/lake/StarMgrMetaSyncer.java Outdated Show resolved Hide resolved

wxl24life force-pushed the xiaolong/github-support-delete-shard-meta-only-in-fe branch 3 times, most recently from 8e820e3 to 1dea62d Compare December 19, 2024 09:43

add config to support delete shard from fe onlyfix

4fe9157

Signed-off-by: drake_wang <[email protected]>

wxl24life force-pushed the xiaolong/github-support-delete-shard-meta-only-in-fe branch from 1dea62d to 4fe9157 Compare December 19, 2024 23:07

fix ut..

5ee6e37

Signed-off-by: drake_wang <[email protected]>

wxl24life force-pushed the xiaolong/github-support-delete-shard-meta-only-in-fe branch from e1bc744 to 5ee6e37 Compare December 24, 2024 09:25

kevincai approved these changes Dec 25, 2024

View reviewed changes

kevincai enabled auto-merge (squash) December 25, 2024 07:27

kevincai requested a review from wyb December 25, 2024 07:27

wyb approved these changes Dec 25, 2024

View reviewed changes

kevincai merged commit ffbd98b into StarRocks:main Dec 25, 2024
48 checks passed

github-actions bot removed the 3.4 label Dec 25, 2024

github-actions bot removed the 3.3 label Dec 25, 2024

mergify bot pushed a commit that referenced this pull request Dec 25, 2024

[Enhancement] Support only deleting shard meta from fe for shared-dat…

566a2b7

…a cluster (#53141) Signed-off-by: drake_wang <[email protected]> (cherry picked from commit ffbd98b)

mergify bot mentioned this pull request Dec 25, 2024

[Enhancement] Support only deleting shard meta from fe for shared-data cluster (backport #53141) #54321

Merged

18 tasks

mergify bot pushed a commit that referenced this pull request Dec 25, 2024

[Enhancement] Support only deleting shard meta from fe for shared-dat…

0760fbe

…a cluster (#53141) Signed-off-by: drake_wang <[email protected]> (cherry picked from commit ffbd98b)

mergify bot mentioned this pull request Dec 25, 2024

[Enhancement] Support only deleting shard meta from fe for shared-data cluster (backport #53141) #54322

Merged

18 tasks

wxl24life deleted the xiaolong/github-support-delete-shard-meta-only-in-fe branch December 25, 2024 08:26

wanpengfei-git pushed a commit that referenced this pull request Dec 27, 2024

[Enhancement] Support only deleting shard meta from fe for shared-dat…

2c7efa5

…a cluster (backport #53141) (#54321) Co-authored-by: Drake Wang <[email protected]>

github-actions bot added the 3.4-merged label Dec 27, 2024

wanpengfei-git pushed a commit that referenced this pull request Dec 27, 2024

[Enhancement] Support only deleting shard meta from fe for shared-dat…

e11e13c

…a cluster (backport #53141) (#54322) Co-authored-by: Drake Wang <[email protected]>

github-actions bot added the 3.3-merged label Dec 27, 2024

maggie-zhu pushed a commit to maggie-zhu/starrocks that referenced this pull request Jan 6, 2025

[Enhancement] Support only deleting shard meta from fe for shared-dat…

ea471e1

…a cluster (StarRocks#53141) Signed-off-by: drake_wang <[email protected]>

zhangyifan27 pushed a commit to zhangyifan27/starrocks that referenced this pull request Feb 10, 2025

[Enhancement] Support only deleting shard meta from fe for shared-dat…

041931a

…a cluster (backport StarRocks#53141) (StarRocks#54322) Co-authored-by: Drake Wang <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Enhancement] Support only deleting shard meta from fe for shared-data cluster #53141

[Enhancement] Support only deleting shard meta from fe for shared-data cluster #53141

wxl24life commented Nov 22, 2024 •

edited

Loading

sonarqubecloud bot commented Dec 24, 2024

github-actions bot commented Dec 25, 2024

github-actions bot commented Dec 25, 2024

github-actions bot commented Dec 25, 2024

github-actions bot commented Dec 25, 2024

github-actions bot commented Dec 25, 2024

mergify bot commented Dec 25, 2024 •

edited

Loading

mergify bot commented Dec 25, 2024 •

edited

Loading

[Enhancement] Support only deleting shard meta from fe for shared-data cluster #53141

[Enhancement] Support only deleting shard meta from fe for shared-data cluster #53141

Conversation

wxl24life commented Nov 22, 2024 • edited Loading

Why I'm doing:

What I'm doing:

What type of PR is this:

Checklist:

Bugfix cherry-pick branch check:

sonarqubecloud bot commented Dec 24, 2024

Quality Gate passed

github-actions bot commented Dec 25, 2024

[Java-Extensions Incremental Coverage Report]

github-actions bot commented Dec 25, 2024

[FE Incremental Coverage Report]

file detail

github-actions bot commented Dec 25, 2024

[BE Incremental Coverage Report]

github-actions bot commented Dec 25, 2024

github-actions bot commented Dec 25, 2024

mergify bot commented Dec 25, 2024 • edited Loading

✅ Backports have been created

mergify bot commented Dec 25, 2024 • edited Loading

✅ Backports have been created

wxl24life commented Nov 22, 2024 •

edited

Loading

mergify bot commented Dec 25, 2024 •

edited

Loading

mergify bot commented Dec 25, 2024 •

edited

Loading