[Enhancement]implement to_days function in FE #51455

even986025158 · 2024-09-26T09:21:49Z

Why I'm doing:

If the where condition contains a partition condition that is compared with the to_days function, a full table scan will be required, and FE is required to implement the to_days function to perform partition pruning when generating the execution plan.

What I'm doing:

implement to_days function in FE

What type of PR is this:

Does this PR entail a change in behavior?

Yes, this PR will result in a change in behavior.
No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

Interface/UI changes: syntax, type conversion, expression evaluation, display information
Parameter changes: default values, similar parameters but with different default values
Policy changes: use new policy to replace old one, functionality automatically enabled
Feature removed
Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

I have added test cases for my bug fix or my new feature
This pr needs user documentation (for new or modified features or behaviors)
- I have added documentation for my new feature or new function
This is a backport pr

实现前:

实现后:

Bugfix cherry-pick branch check:

fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rewrite/ScalarOperatorFunctions.java

Signed-off-by: evenhuang <[email protected]>

sonarqubecloud · 2024-09-26T09:49:39Z

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

github-actions · 2024-09-26T11:13:14Z

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

github-actions · 2024-09-26T11:13:51Z

[FE Incremental Coverage Report]

✅ pass : 4 / 4 (100.00%)

file detail

	path	covered_line	new_line	coverage	not_covered_line_detail
🔵	com/starrocks/sql/optimizer/rewrite/ScalarOperatorFunctions.java	4	4	100.00%	[]

github-actions · 2024-09-26T11:14:03Z

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

github-actions · 2024-10-09T03:45:51Z

@Mergifyio backport branch-3.3

github-actions · 2024-10-09T03:45:53Z

@Mergifyio backport branch-3.2

github-actions · 2024-10-09T03:45:54Z

@Mergifyio backport branch-3.1

github-actions · 2024-10-09T03:45:55Z

@Mergifyio backport branch-3.0

github-actions · 2024-10-09T03:45:57Z

@Mergifyio backport branch-2.5

mergify · 2024-10-09T03:46:10Z

backport branch-3.3

✅ Backports have been created

#51651 [Enhancement]implement to_days function in FE (backport #51455) has been created for branch branch-3.3

mergify · 2024-10-09T03:46:12Z

backport branch-3.2

✅ Backports have been created

#51650 [Enhancement]implement to_days function in FE (backport #51455) has been created for branch branch-3.2

mergify · 2024-10-09T03:46:13Z

backport branch-3.1

✅ Backports have been created

#51652 [Enhancement]implement to_days function in FE (backport #51455) has been created for branch branch-3.1 but encountered conflicts

mergify · 2024-10-09T03:46:14Z

backport branch-3.0

✅ Backports have been created

#51653 [Enhancement]implement to_days function in FE (backport #51455) has been created for branch branch-3.0 but encountered conflicts

mergify · 2024-10-09T03:46:15Z

backport branch-2.5

✅ Backports have been created

#51654 [Enhancement]implement to_days function in FE (backport #51455) has been created for branch branch-2.5 but encountered conflicts

Signed-off-by: evenhuang <[email protected]> (cherry picked from commit dfb309d)

Signed-off-by: evenhuang <[email protected]> (cherry picked from commit dfb309d) # Conflicts: # fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rewrite/ScalarOperatorFunctions.java

wangsimo0 · 2024-10-09T12:42:11Z

ignore backport check: 3.3.5

Signed-off-by: evenhuang <[email protected]> Signed-off-by: zhiminr.ren <[email protected]>

even986025158 requested a review from a team as a code owner September 26, 2024 09:21

github-actions bot added behavior_changed 3.3 3.2 3.1 3.0 2.5 labels Sep 26, 2024

mergify bot assigned even986025158 Sep 26, 2024

starrocks-cr bot reviewed Sep 26, 2024

View reviewed changes

fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rewrite/ScalarOperatorFunctions.java Show resolved Hide resolved

even986025158 force-pushed the community/to_days_fe branch from 0a4fbb7 to 32ab9a0 Compare September 26, 2024 09:28

implement to_days function in FE

d07b3d1

Signed-off-by: evenhuang <[email protected]>

even986025158 force-pushed the community/to_days_fe branch from 32ab9a0 to d07b3d1 Compare September 26, 2024 09:37

kangkaisen approved these changes Oct 9, 2024

View reviewed changes

trueeyu approved these changes Oct 9, 2024

View reviewed changes

trueeyu merged commit dfb309d into StarRocks:main Oct 9, 2024
48 checks passed

github-actions bot removed the 3.3 label Oct 9, 2024

github-actions bot removed the 3.2 label Oct 9, 2024

github-actions bot removed 3.1 3.0 labels Oct 9, 2024

github-actions bot removed the 2.5 label Oct 9, 2024

mergify bot pushed a commit that referenced this pull request Oct 9, 2024

[Enhancement]implement to_days function in FE (#51455)

f34bee6

Signed-off-by: evenhuang <[email protected]> (cherry picked from commit dfb309d)

mergify bot pushed a commit that referenced this pull request Oct 9, 2024

[Enhancement]implement to_days function in FE (#51455)

958e760

Signed-off-by: evenhuang <[email protected]> (cherry picked from commit dfb309d)

This was referenced Oct 9, 2024

[Enhancement]implement to_days function in FE (backport #51455) #51650

Open

[Enhancement]implement to_days function in FE (backport #51455) #51651

Open

mergify bot mentioned this pull request Oct 9, 2024

[Enhancement]implement to_days function in FE (backport #51455) #51652

Closed

42 tasks

This was referenced Oct 9, 2024

[Enhancement]implement to_days function in FE (backport #51455) #51653

Closed

[Enhancement]implement to_days function in FE (backport #51455) #51654

Closed

github-actions bot added 3.2 3.1 3.0 2.5 and removed 3.2 3.1 3.0 2.5 labels Oct 9, 2024

renzhimin7 pushed a commit to renzhimin7/starrocks that referenced this pull request Nov 7, 2024

[Enhancement]implement to_days function in FE (StarRocks#51455)

2b5ce86

Signed-off-by: evenhuang <[email protected]> Signed-off-by: zhiminr.ren <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Enhancement]implement to_days function in FE #51455

[Enhancement]implement to_days function in FE #51455

even986025158 commented Sep 26, 2024 •

edited by kangkaisen

Loading

sonarqubecloud bot commented Sep 26, 2024

github-actions bot commented Sep 26, 2024

github-actions bot commented Sep 26, 2024

github-actions bot commented Sep 26, 2024

github-actions bot commented Oct 9, 2024

github-actions bot commented Oct 9, 2024

github-actions bot commented Oct 9, 2024

github-actions bot commented Oct 9, 2024

github-actions bot commented Oct 9, 2024

mergify bot commented Oct 9, 2024 •

edited

Loading

mergify bot commented Oct 9, 2024 •

edited

Loading

mergify bot commented Oct 9, 2024 •

edited

Loading

mergify bot commented Oct 9, 2024 •

edited

Loading

mergify bot commented Oct 9, 2024 •

edited

Loading

wangsimo0 commented Oct 9, 2024

[Enhancement]implement to_days function in FE #51455

[Enhancement]implement to_days function in FE #51455

Conversation

even986025158 commented Sep 26, 2024 • edited by kangkaisen Loading

Why I'm doing:

What I'm doing:

What type of PR is this:

Checklist:

Bugfix cherry-pick branch check:

sonarqubecloud bot commented Sep 26, 2024

Quality Gate passed

github-actions bot commented Sep 26, 2024

[Java-Extensions Incremental Coverage Report]

github-actions bot commented Sep 26, 2024

[FE Incremental Coverage Report]

file detail

github-actions bot commented Sep 26, 2024

[BE Incremental Coverage Report]

github-actions bot commented Oct 9, 2024

github-actions bot commented Oct 9, 2024

github-actions bot commented Oct 9, 2024

github-actions bot commented Oct 9, 2024

github-actions bot commented Oct 9, 2024

mergify bot commented Oct 9, 2024 • edited Loading

✅ Backports have been created

mergify bot commented Oct 9, 2024 • edited Loading

✅ Backports have been created

mergify bot commented Oct 9, 2024 • edited Loading

✅ Backports have been created

mergify bot commented Oct 9, 2024 • edited Loading

✅ Backports have been created

mergify bot commented Oct 9, 2024 • edited Loading

✅ Backports have been created

wangsimo0 commented Oct 9, 2024

even986025158 commented Sep 26, 2024 •

edited by kangkaisen

Loading

mergify bot commented Oct 9, 2024 •

edited

Loading

mergify bot commented Oct 9, 2024 •

edited

Loading

mergify bot commented Oct 9, 2024 •

edited

Loading

mergify bot commented Oct 9, 2024 •

edited

Loading

mergify bot commented Oct 9, 2024 •

edited

Loading