-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BugFix] Capture resource group for scan task #51121
Merged
ZiheLiu
merged 1 commit into
StarRocks:main
from
ZiheLiu:fix/main/rg_scan_task_queue_delete
Sep 20, 2024
Merged
[BugFix] Capture resource group for scan task #51121
ZiheLiu
merged 1 commit into
StarRocks:main
from
ZiheLiu:fix/main/rg_scan_task_queue_delete
Sep 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zihe.liu <[email protected]>
c258e32
to
3808b3e
Compare
satanson
approved these changes
Sep 19, 2024
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]❌ fail : 11 / 18 (61.11%) file detail
|
kangkaisen
approved these changes
Sep 19, 2024
@Mergifyio backport branch-3.3 |
@Mergifyio backport branch-3.2 |
@Mergifyio backport branch-3.1 |
@Mergifyio backport branch-3.0 |
@Mergifyio backport branch-2.5 |
✅ Backports have been created
|
✅ Backports have been created
|
✅ Backports have been created
|
✅ Backports have been created
|
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Sep 20, 2024
Signed-off-by: zihe.liu <[email protected]> (cherry picked from commit 3317f49)
42 tasks
mergify bot
pushed a commit
that referenced
this pull request
Sep 20, 2024
Signed-off-by: zihe.liu <[email protected]> (cherry picked from commit 3317f49) # Conflicts: # be/src/exec/pipeline/exchange/mem_limited_chunk_queue.cpp # be/src/exec/pipeline/hashjoin/spillable_hash_join_probe_operator.cpp # be/src/exec/spill/executor.h # be/src/exec/spill/spiller.hpp # be/src/exec/workgroup/scan_task_queue.cpp # be/src/exec/workgroup/scan_task_queue.h # be/src/udf/java/utils.cpp
42 tasks
mergify bot
pushed a commit
that referenced
this pull request
Sep 20, 2024
Signed-off-by: zihe.liu <[email protected]> (cherry picked from commit 3317f49) # Conflicts: # be/src/exec/pipeline/exchange/mem_limited_chunk_queue.cpp # be/src/exec/pipeline/hashjoin/spillable_hash_join_probe_operator.cpp # be/src/exec/spill/executor.h # be/src/exec/spill/spiller.hpp # be/src/exec/workgroup/scan_task_queue.cpp # be/src/exec/workgroup/scan_task_queue.h # be/src/udf/java/utils.cpp
mergify bot
pushed a commit
that referenced
this pull request
Sep 20, 2024
Signed-off-by: zihe.liu <[email protected]> (cherry picked from commit 3317f49) # Conflicts: # be/src/exec/pipeline/exchange/mem_limited_chunk_queue.cpp # be/src/exec/pipeline/hashjoin/spillable_hash_join_probe_operator.cpp # be/src/exec/spill/executor.h # be/src/exec/spill/spiller.hpp # be/src/exec/workgroup/scan_task_queue.cpp # be/src/exec/workgroup/scan_task_queue.h # be/src/udf/java/utils.cpp
mergify bot
pushed a commit
that referenced
this pull request
Sep 20, 2024
Signed-off-by: zihe.liu <[email protected]> (cherry picked from commit 3317f49) # Conflicts: # be/src/exec/pipeline/exchange/mem_limited_chunk_queue.cpp # be/src/exec/pipeline/hashjoin/spillable_hash_join_probe_operator.cpp # be/src/exec/spill/executor.h # be/src/exec/spill/spiller.hpp # be/src/exec/workgroup/scan_task_queue.cpp # be/src/exec/workgroup/scan_task_queue.h # be/src/udf/java/utils.cpp
This was referenced Sep 20, 2024
wanpengfei-git
pushed a commit
that referenced
this pull request
Sep 20, 2024
Co-authored-by: zihe.liu <[email protected]>
ZiheLiu
added a commit
to ZiheLiu/starrocks
that referenced
this pull request
Sep 27, 2024
Signed-off-by: zihe.liu <[email protected]>
24 tasks
ZiheLiu
added a commit
to ZiheLiu/starrocks
that referenced
this pull request
Sep 27, 2024
Signed-off-by: zihe.liu <[email protected]>
This was referenced Sep 27, 2024
satanson
pushed a commit
that referenced
this pull request
Sep 27, 2024
Signed-off-by: zihe.liu <[email protected]>
satanson
pushed a commit
that referenced
this pull request
Sep 27, 2024
Signed-off-by: zihe.liu <[email protected]>
satanson
pushed a commit
that referenced
this pull request
Sep 27, 2024
Signed-off-by: zihe.liu <[email protected]>
renzhimin7
pushed a commit
to renzhimin7/starrocks
that referenced
this pull request
Nov 7, 2024
Signed-off-by: zihe.liu <[email protected]> Signed-off-by: zhiminr.ren <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
The scan task queue is a two-level queue:
workgroup_entity
queue, which stores raw pointers toworkgroup_entity
. Theseworkgroup_entities
are owned by their workgroups.workgroup_entity
contains an internal task queue. Each task within this queue also has a raw pointer to the associated workgroup.When retrieving a task from the scan task queue, the process first accesses the
workgroup_entity
and then extracts a task from the internal task queue of thatworkgroup_entity
.However, the lifecycle of a scan task can be longer than that of the corresponding pipeline driver and workgroup. When executing the SQL command
DROP RESOURCE GROUP
, the workgroup is deleted once all associated pipeline drivers have completed.This can lead to a situation where the
workgroup_entity
and its corresponding tasks still reside in the scan task queue, but the workgroup itself has already been released. In such cases, accessing theworkgroup_entity
results in a "use-after-free" error.What I'm doing:
To prevent this issue, each task should hold a shared pointer to the workgroup. This ensures that the workgroup will not be deleted as long as there are tasks in the scan task queue referencing it.
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: