[BugFix] Fix information_schema.fe_locks schema table visit bug (#45927)

Signed-off-by: shuming.li <[email protected]>
StarRocks · May 21, 2024 · a2460eb · a2460eb
1 parent 2bb8e40
commit a2460eb
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 4 deletions.
diff --git a/be/src/exec/schema_scanner/sys_fe_locks.cpp b/be/src/exec/schema_scanner/sys_fe_locks.cpp
@@ -43,12 +43,12 @@ Status SysFeLocks::start(RuntimeState* state) {
     RETURN_IF(!_param->ip || !_param->port, Status::InternalError("IP or port not exists"));
 
     RETURN_IF_ERROR(SchemaScanner::start(state));
+    RETURN_IF_ERROR(SchemaScanner::init_schema_scanner_state(state));
 
     TAuthInfo auth = build_auth_info();
     TFeLocksReq request;
     request.__set_auth_info(auth);
-
-    return (SchemaHelper::list_fe_locks(_ss_state, request, &_result));
+    return SchemaHelper::list_fe_locks(_ss_state, request, &_result);
 }
 
 Status SysFeLocks::_fill_chunk(ChunkPtr* chunk) {

diff --git a/be/src/exec/schema_scanner/sys_fe_memory_usage.cpp b/be/src/exec/schema_scanner/sys_fe_memory_usage.cpp
@@ -44,7 +44,7 @@ Status SysFeMemoryUsage::start(RuntimeState* state) {
     TFeMemoryReq request;
     request.__set_auth_info(auth);
 
-    return (SchemaHelper::list_fe_memory_usage(_ss_state, request, &_result));
+    return SchemaHelper::list_fe_memory_usage(_ss_state, request, &_result);
 }
 
 Status SysFeMemoryUsage::_fill_chunk(ChunkPtr* chunk) {

diff --git a/be/src/exec/schema_scanner/sys_object_dependencies.cpp b/be/src/exec/schema_scanner/sys_object_dependencies.cpp
@@ -52,7 +52,7 @@ Status SysObjectDependencies::start(RuntimeState* state) {
     TObjectDependencyReq request;
     request.__set_auth_info(auth);
 
-    return (SchemaHelper::list_object_dependencies(_ss_state, request, &_result));
+    return SchemaHelper::list_object_dependencies(_ss_state, request, &_result);
 }
 
 Status SysObjectDependencies::_fill_chunk(ChunkPtr* chunk) {

diff --git a/test/sql/test_sys/R/test_fe_locks b/test/sql/test_sys/R/test_fe_locks
@@ -0,0 +1,2 @@
+-- name: test_fe_locks
+[UC] select count(*) > 1 from sys.fe_locks;
diff --git a/test/sql/test_sys/T/test_fe_locks b/test/sql/test_sys/T/test_fe_locks
@@ -0,0 +1,2 @@
+-- name: test_fe_locks
+select count(*) > 1 from sys.fe_locks;
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		-- name: test_fe_locks
		[UC] select count(*) > 1 from sys.fe_locks;
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		-- name: test_fe_locks
		select count(*) > 1 from sys.fe_locks;