-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ConfigureTipKit Module #38
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @Supereg; had a similar comment to StanfordSpezi/Spezi#106 about the SwiftLint dependency but apart from this and small docs improvements this PR looks good to me 🚀
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #38 +/- ##
==========================================
+ Coverage 80.27% 80.36% +0.09%
==========================================
Files 43 44 +1
Lines 1282 1298 +16
==========================================
+ Hits 1029 1043 +14
- Misses 253 255 +2
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the improvements @Supereg! 🚀
Add ConfigureTipKit Module
♻️ Current situation & Problem
This PR adds the
ConfigureTipKit
module to easily configure TipKit (or require TipKit to be configured) across the Spezi framework ecosystem.⚙️ Release Notes
ConfigureTipKit
module.📚 Documentation
Documentation catalog was adjusted.
✅ Testing
Basic testing was added that calls the new code paths.
📝 Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: