Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SwiftUI Binding Negation #32

Merged
merged 2 commits into from
Feb 26, 2024
Merged

Conversation

philippzagar
Copy link
Member

Add SwiftUI Binding Negation

♻️ Current situation & Problem

We currently use the negation of a SwiftUI Binding in lots of different Spezi modules.
Each module needs to define the Binding extension on their own.

⚙️ Release Notes

  • Adds a SwiftUI Binding Negation

📚 Documentation

Proper documentation of added code

✅ Testing

No test cases added

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@philippzagar philippzagar added the enhancement New feature or request label Feb 26, 2024
@philippzagar philippzagar self-assigned this Feb 26, 2024
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 79.48%. Comparing base (d49f716) to head (a012d0f).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #32      +/-   ##
==========================================
- Coverage   79.87%   79.48%   -0.39%     
==========================================
  Files          39       40       +1     
  Lines        1222     1228       +6     
==========================================
  Hits          976      976              
- Misses        246      252       +6     
Files Coverage Δ
Sources/SpeziViews/Utilities/Binding+Negate.swift 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d49f716...a012d0f. Read the comment docs.

Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you; looks great!

@philippzagar
Copy link
Member Author

@PSchmiedmayer Please force-merge the PR, I didn't do testing for this one as it's really basic functionality

@PSchmiedmayer PSchmiedmayer merged commit 1cf188c into main Feb 26, 2024
12 of 13 checks passed
@PSchmiedmayer PSchmiedmayer deleted the feat/add-binding-negation branch February 26, 2024 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants